Prioritize node wallet frontiers during background confirmations #2154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wezrule
added
the
quality improvements
cryptocode
approved these changes
Jul 16, 2019
SergiySW
reviewed
Jul 18, 2019
SergiySW
reviewed
Jul 18, 2019
SergiySW
reviewed
Jul 18, 2019
SergiySW
approved these changes
Aug 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we prioritize based on the number of uncemented blocks on all accounts in the ledger. This PR still does that, but gives a greater priority to all node wallet accounts first (again sorted by uncemented blocks).
(Unrelated) nano/node/wallet.hpp I noticed some function delcarations had no definitions so removed them.
TSAN has been run on core_tests and showed no warnings.