Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Accept multiplier in work_generate and work_validate #2151

Merged
merged 1 commit into from
Jul 31, 2019
Merged

Accept multiplier in work_generate and work_validate #2151

merged 1 commit into from
Jul 31, 2019

Conversation

guilhermelawless
Copy link
Contributor

@guilhermelawless guilhermelawless commented Jul 14, 2019 •
edited
Loading

  • Adds difficulty_optional_impl() and multiplier_optional_impl()
  • Multiplier overrides difficulty if both given
  • Multiplier is tested to be valid and > 0

Accept multiplier in work_generate and work_validate
c50a048 
Add difficulty_optional_impl() and multiplier_optional_impl()
Multiplier overrides difficulty if both given
@zhyatt zhyatt added this to the V20.0 milestone Jul 15, 2019
@zhyatt zhyatt requested review from SergiySW, wezrule and argakiig and removed request for wezrule July 29, 2019 22:45
@zhyatt zhyatt removed the request for review from SergiySW July 31, 2019 15:59
guilhermelawless added a commit to guilhermelawless/nano-docs that referenced this pull request Jul 31, 2019
@guilhermelawless
Multiplier option in RPCs work_generate and work_validate.
921a8af 
Following nanocurrency/nano-node#2151
@guilhermelawless guilhermelawless mentioned this pull request Jul 31, 2019
Merged
@argakiig argakiig merged commit fcb153f into nanocurrency:master Jul 31, 2019
zhyatt pushed a commit to nanocurrency/nano-docs that referenced this pull request Jul 31, 2019
@zhyatt
Multiplier option in RPCs work_generate and work_validate. (#65)
efdb869 
Following nanocurrency/nano-node#2151
@guilhermelawless guilhermelawless mentioned this pull request Jul 31, 2019
Merged
@guilhermelawless guilhermelawless deleted the rpc/work-generate-multiplier branch July 31, 2019 19:27
@guilhermelawless guilhermelawless mentioned this pull request Aug 2, 2019
Merged
GuyWhoKnowsTheGuy pushed a commit to GuyWhoKnowsTheGuy/nano-docs that referenced this pull request Aug 9, 2019
@GuyWhoKnowsTheGuy
Multiplier option in RPCs work_generate and work_validate. (nanocurre…
cc5e3e2 
…ncy#65)

Following nanocurrency/nano-node#2151
@zhyatt zhyatt added rpc Changes related to Remote Procedure Calls semantic Change to node APIs (separate label) which impacts interpretation of data, integrations impacted. and removed rpc semantics change labels Mar 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@argakiig argakiig argakiig approved these changes

Assignees

@guilhermelawless guilhermelawless

Labels
enhancement rpc Changes related to Remote Procedure Calls semantic Change to node APIs (separate label) which impacts interpretation of data, integrations impacted.
Projects
None yet
Milestone
V20.0
Development

Successfully merging this pull request may close these issues.
3 participants
@guilhermelawless @argakiig @zhyatt