Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove extra core utilised during docker deployment build #2150

Merged
merged 1 commit into from
Jul 15, 2019

Conversation

wezrule
Copy link
Contributor

@wezrule wezrule commented Jul 13, 2019

The travis docker deployment cannot handle the additional core added in #2148, otherwise the error
virtual memory exhausted: Cannot allocate memory is given near the end of the build many times. It can handle the same number though, so I'm just removing the extra one. Using nproc instead now which is simpler than how I was determining the number of cores before.

For my sanity next time (and in case anyone else needs to do this), the following steps can be done to check the deployment build without have to merge into master:
1 - .travis.yml - Under stages, remove all except deploy. Under jobs -> include, remove all except deploy.
2 - ci/deploy-docker.sh - Replace this file with:

#!/bin/bash
set -e
docker build --build-arg NETWORK=live -f docker/node/Dockerfile -t any_name_you_want .

@wezrule wezrule added this to the V20.0 milestone Jul 13, 2019
@wezrule wezrule requested a review from argakiig July 13, 2019 21:24
@wezrule wezrule self-assigned this Jul 13, 2019
@wezrule wezrule merged commit 0bbc02b into nanocurrency:master Jul 15, 2019
@wezrule wezrule deleted the use_less_cores_docker branch July 15, 2019 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants