Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide alternative method to download ledger file #294

Merged
merged 1 commit into from
May 20, 2020

Conversation

jserv
Copy link
Contributor

@jserv jserv commented May 18, 2020

My Nano Ninja API can redirect the current ledger file preserved at
Yandex. It is convenient for Docker and/or shell scripting integration.

@zhyatt
Copy link
Contributor

zhyatt commented May 18, 2020

@BitDesert I didn't realize your API call for ledger downloads was based on the ledger file provided by @SergiySW. Can you confirm that and also let us know if you are comfortable with us listing that endpoint in the docs here?

@zhyatt zhyatt self-requested a review May 18, 2020 15:25
@BitDesert
Copy link
Contributor

Sure thing! It's just calls the newest file from the Yandex Disk and redirects to it:
https://github.com/BitDesert/MyNanoNinja/blob/2b4ae723eb648de7366b4446f1b3422876d76fe5/routes/api.js#L36-L47

@jserv
Copy link
Contributor Author

jserv commented May 18, 2020

Sure thing! It's just calls the newest file from the Yandex Disk and redirects to it:
https://github.com/BitDesert/MyNanoNinja/blob/2b4ae723eb648de7366b4446f1b3422876d76fe5/routes/api.js#L36-L47

By the way, can My Nano Ninja API retrieve checksum for ledger file as well?

@BitDesert
Copy link
Contributor

BitDesert commented May 18, 2020

@jserv I could provide a sha256/md5 hash if you want.

Edit:
Added both:
https://mynano.ninja/api/ledger/checksum/sha256
https://mynano.ninja/api/ledger/checksum/md5

@jserv
Copy link
Contributor Author

jserv commented May 19, 2020

Thank @BitDesert for the prompt support. I have revised the changes for sha256 checksum.

@zhyatt zhyatt requested a review from SergiySW May 19, 2020 19:51
@zhyatt
Copy link
Contributor

zhyatt commented May 19, 2020

Thanks @BitDesert and @jserv for helping sort this out. @SergiySW Any issues you see with the requested update/commands?

@SergiySW
Copy link
Contributor

Well, not sure if it's better to specify size of compressed ledger as 11GB (and it can change over time) or provide method to validate size as well

My Nano Ninja API can redirect the current ledger file preserved at
Yandex. It is convenient for Docker and/or shell scripting integration.
@jserv
Copy link
Contributor Author

jserv commented May 19, 2020

Well, not sure if it's better to specify size of compressed ledger as 11GB (and it can change over time) or provide method to validate size as well

Using file checksum integrity verification should be sufficient. This pull request makes sense to someone who is writing scripts to automate ledger file downloading.

Copy link
Contributor

@SergiySW SergiySW left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhyatt zhyatt merged commit e4de3e4 into nanocurrency:master May 20, 2020
@zhyatt
Copy link
Contributor

zhyatt commented May 20, 2020

Thanks @jserv !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants