-
-
Notifications
You must be signed in to change notification settings - Fork 310
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Bevy Plugin Refactor #1005
Draft
mitchmindtree
wants to merge
350
commits into
master
Choose a base branch
from
bevy-refactor
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pacakge Remove old `nannou-new` and `nannou-package` crates
…-dep fix: change `bevy_nannou_derive` to only expect the presence of `bevy_nannou`, not the `nannou` crate
refactor: Use only necessary `bevy` features in `bevy_nannou`, `bevy_nannou_draw`
Update workspace dependencies structure
Update workspace deps to use latest versions
WebGL appears to have a requirement that initialised buffers must have a non-zero length (or something along these lines). This changes our draw logic to lazily initialise the mesh to work around this requirement.
fix: Lazily initialize Mesh in draw commands for webgl2 compat
chore: update bevy_egui
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This WIP PR contains all the amazing work involved in the bevy-refactor overhaul lead by @tychedelia!
Opening this as a draft as an easy place to check out and discuss the diff.
Closes #953.