All for submission of Frame prior to the end of view

This allows the user to ensure that the command buffer responsible for
drawing to the swap chain texture is submitted prior to the end of their
`view` function. This is necessary to allow the user to read back
buffers and textures involved in drawing to the texture at the end of
the `view` function. Without this change, it is not possible to do so in
nannou's current API.

The most significant user-impacting change is that the `view` functions
now take the `Frame` by value, rather than by reference.

examples/all_functions.rs

@@ -54,7 +54,7 @@ fn event(_app: &App, _model: &mut Model, event: Event) {
 
 fn update(_app: &App, _model: &mut Model, _update: Update) {}
 
-fn view(_app: &App, _model: &Model, frame: &Frame) {
+fn view(_app: &App, _model: &Model, frame: Frame) {
     frame.clear(SKYBLUE);
 }
 

examples/basics/1_nannou_events.rs

@@ -57,6 +57,6 @@ fn event(_app: &App, _model: &mut Model, event: WindowEvent) {
 }
 
 // Put your drawing code, called once per frame, per window.
-fn view(_app: &App, _model: &Model, frame: &Frame) {
+fn view(_app: &App, _model: &Model, frame: Frame) {
     frame.clear(DIMGRAY);
 }

examples/basics/2_variables_window_console.rs

@@ -27,6 +27,6 @@ fn model(app: &App) -> Model {
     Model
 }
 
-fn view(_app: &App, _model: &Model, frame: &Frame) {
+fn view(_app: &App, _model: &Model, frame: Frame) {
     frame.clear(DIMGRAY);
 }

examples/basics/3_variable_scope.rs

@@ -40,6 +40,6 @@ fn event(_app: &App, model: &mut Model, event: WindowEvent) {
     }
 }
 
-fn view(_app: &App, _model: &Model, frame: &Frame) {
+fn view(_app: &App, _model: &Model, frame: Frame) {
     frame.clear(DIMGRAY);
 }

examples/basics/4_conditionals.rs

@@ -4,7 +4,7 @@ fn main() {
     nannou::sketch(view);
 }
 
-fn view(app: &App, frame: &Frame) {
+fn view(app: &App, frame: Frame) {
     // Prepare to draw.
     let draw = app.draw();
 

examples/basics/5_loops.rs

@@ -42,6 +42,6 @@ fn model(_app: &App) -> Model {
     Model
 }
 
-fn view(_app: &App, _model: &Model, frame: &Frame) {
+fn view(_app: &App, _model: &Model, frame: Frame) {
     frame.clear(DIMGRAY);
 }

examples/basics/6_functions.rs

@@ -52,6 +52,6 @@ fn event(_app: &App, _model: &mut Model, event: WindowEvent) {
     }
 }
 
-fn view(_app: &App, _model: &Model, frame: &Frame) {
+fn view(_app: &App, _model: &Model, frame: Frame) {
     frame.clear(DIMGRAY);
 }

examples/basics/7_modules/7_modules.rs

@@ -23,7 +23,7 @@ fn update(app: &App, model: &mut Model, _update: Update) {
     model.ball.position = pt2(app.mouse.x, app.mouse.y);
 }
 
-fn view(app: &App, model: &Model, frame: &Frame) {
+fn view(app: &App, model: &Model, frame: Frame) {
     // Begin drawing.
     let draw = app.draw();
     // Draw dark gray for the background

examples/generative_design/color/p_1_0_01.rs

@@ -34,7 +34,7 @@ fn main() {
     nannou::sketch(view);
 }
 
-fn view(app: &App, frame: &Frame) {
+fn view(app: &App, frame: Frame) {
     app.main_window().set_inner_size_points(720.0, 720.0);
 
     // Prepare to draw.

examples/generative_design/color/p_1_1_1_01.rs

@@ -29,7 +29,7 @@ fn main() {
     nannou::sketch(view);
 }
 
-fn view(app: &App, frame: &Frame) {
+fn view(app: &App, frame: Frame) {
     app.main_window().set_inner_size_pixels(800, 400);
 
     // Begin drawing

examples/generative_design/color/p_1_1_2_01.rs

@@ -74,7 +74,7 @@ fn key_pressed(_app: &App, model: &mut Model, key: Key) {
     }
 }
 
-fn view(app: &App, model: &Model, frame: &Frame) {
+fn view(app: &App, model: &Model, frame: Frame) {
     // Begin drawing
     let draw = app.draw();
 

examples/generative_design/color/p_1_2_1_01.rs

@@ -76,7 +76,7 @@ fn update(app: &App, model: &mut Model, _update: Update) {
     model.tile_count_y = map_range(app.mouse.y, win.top(), win.bottom(), 2, 10) as usize;
 }
 
-fn view(app: &App, model: &Model, frame: &Frame) {
+fn view(app: &App, model: &Model, frame: Frame) {
     // Begin drawing
     let draw = app.draw();
     draw.background().color(BLACK);

examples/generative_design/color/p_1_2_3_01.rs

@@ -154,7 +154,7 @@ fn key_pressed(_app: &App, model: &mut Model, key: Key) {
     }
 }
 
-fn view(app: &App, model: &Model, frame: &Frame) {
+fn view(app: &App, model: &Model, frame: Frame) {
     // Begin drawing
     let draw = app.draw();
 

examples/generative_design/color/p_1_2_3_02.rs

@@ -87,7 +87,7 @@ fn update(app: &App, model: &mut Model, _update: Update) {
     }
 }
 
-fn view(app: &App, model: &Model, frame: &Frame) {
+fn view(app: &App, model: &Model, frame: Frame) {
     let draw = app.draw();
 
     if model.clicked {

examples/generative_design/color/p_1_2_3_03.rs

@@ -89,7 +89,7 @@ fn update(app: &App, model: &mut Model, _update: Update) {
     }
 }
 
-fn view(app: &App, model: &Model, frame: &Frame) {
+fn view(app: &App, model: &Model, frame: Frame) {
     // Begin drawing
     let draw = app.draw();
 

examples/generative_design/oscillation_figures/m_2_1_01.rs

@@ -76,7 +76,7 @@ fn update(app: &App, model: &mut Model, _update: Update) {
     }
 }
 
-fn view(app: &App, model: &Model, frame: &Frame) {
+fn view(app: &App, model: &Model, frame: Frame) {
     let draw = app.draw();
     let win = app.window_rect();
 

examples/generative_design/oscillation_figures/m_2_2_01.rs

@@ -76,7 +76,7 @@ fn update(app: &App, model: &mut Model, _update: Update) {
     model.y *= app.window_rect().h() / 4.0 - model.margin;
 }
 
-fn view(app: &App, model: &Model, frame: &Frame) {
+fn view(app: &App, model: &Model, frame: Frame) {
     // Begin drawing
     let draw = app.draw();
     let win = app.window_rect();

examples/generative_design/oscillation_figures/m_2_3_01.rs

@@ -66,7 +66,7 @@ fn update(app: &App, model: &mut Model, _update: Update) {
     model.point_count = app.window_rect().w() as usize;
 }
 
-fn view(app: &App, model: &Model, frame: &Frame) {
+fn view(app: &App, model: &Model, frame: Frame) {
     // Begin drawing
     let draw = app.draw();
     let win = app.window_rect();

examples/generative_design/oscillation_figures/m_2_3_02.rs

@@ -83,7 +83,7 @@ fn update(app: &App, model: &mut Model, _update: Update) {
     model.point_count = mx as usize * 2 + 200;
 }
 
-fn view(app: &App, model: &Model, frame: &Frame) {
+fn view(app: &App, model: &Model, frame: Frame) {
     // Begin drawing
     let draw = app.draw();
     let win = app.window_rect();

examples/generative_design/oscillation_figures/m_2_5_01.rs

@@ -104,7 +104,7 @@ fn update(app: &App, model: &mut Model, _update: Update) {
     }
 }
 
-fn view(app: &App, model: &Model, frame: &Frame) {
+fn view(app: &App, model: &Model, frame: Frame) {
     let draw = app.draw();
 
     if model.should_draw {

examples/generative_design/oscillation_figures/m_2_5_02.rs

@@ -98,7 +98,7 @@ fn update(_app: &App, model: &mut Model, _update: Update) {
     }
 }
 
-fn view(app: &App, model: &Model, frame: &Frame) {
+fn view(app: &App, model: &Model, frame: Frame) {
     let draw = app.draw();
 
     if app.elapsed_frames() == 1 {

examples/generative_design/random_and_noise/m_1_1_01.rs

@@ -53,7 +53,7 @@ fn model(app: &App) -> Model {
     }
 }
 
-fn view(app: &App, model: &Model, frame: &Frame) {
+fn view(app: &App, model: &Model, frame: Frame) {
     let draw = app.draw();
     let win = app.window_rect();
 

examples/generative_design/random_and_noise/m_1_2_01.rs

@@ -56,7 +56,7 @@ fn model(app: &App) -> Model {
     }
 }
 
-fn view(app: &App, model: &Model, frame: &Frame) {
+fn view(app: &App, model: &Model, frame: Frame) {
     let draw = app.draw();
     let win = app.window_rect();
 

examples/generative_design/random_and_noise/m_1_3_01.rs

@@ -54,7 +54,7 @@ fn model(app: &App) -> Model {
     }
 }
 
-fn view(app: &App, model: &Model, frame: &Frame) {
+fn view(app: &App, model: &Model, frame: Frame) {
     let draw = app.draw();
     let win = app.window_rect();
 

examples/generative_design/shape/p_2_0_01.rs

@@ -35,7 +35,7 @@ fn main() {
     nannou::sketch(view);
 }
 
-fn view(app: &App, frame: &Frame) {
+fn view(app: &App, frame: Frame) {
     app.main_window().set_inner_size_points(550.0, 550.0);
 
     // Prepare to draw.

examples/generative_design/shape/p_2_0_02.rs

@@ -57,7 +57,7 @@ fn model(app: &App) -> Model {
     }
 }
 
-fn view(app: &App, model: &Model, frame: &Frame) {
+fn view(app: &App, model: &Model, frame: Frame) {
     // Prepare to draw.
     let draw = app.draw();
     let win = app.window_rect();

examples/generative_design/shape/p_2_0_03.rs

@@ -60,7 +60,7 @@ fn model(app: &App) -> Model {
     }
 }
 
-fn view(app: &App, model: &Model, frame: &Frame) {
+fn view(app: &App, model: &Model, frame: Frame) {
     // Prepare to draw.
     let draw = app.draw();
     let win = app.window_rect();

examples/generative_design/shape/p_2_1_1_01.rs

@@ -64,7 +64,7 @@ fn model(app: &App) -> Model {
     }
 }
 
-fn view(app: &App, model: &Model, frame: &Frame) {
+fn view(app: &App, model: &Model, frame: Frame) {
     // Prepare to draw.
     let draw = app.draw();
     draw.background().color(BLACK);

examples/generative_design/shape/p_2_1_1_02.rs

@@ -80,7 +80,7 @@ fn model(app: &App) -> Model {
     }
 }
 
-fn view(app: &App, model: &Model, frame: &Frame) {
+fn view(app: &App, model: &Model, frame: Frame) {
     // Prepare to draw.
     let draw = app.draw();
     draw.background().color(WHITE);

examples/generative_design/shape/p_2_1_1_03.rs

@@ -102,7 +102,7 @@ fn update(app: &App, model: &mut Model, _update: Update) {
     }
 }
 
-fn view(app: &App, model: &Model, frame: &Frame) {
+fn view(app: &App, model: &Model, frame: Frame) {
     // Prepare to draw.
     let draw = app.draw();
     draw.background().color(WHITE);

examples/generative_design/shape/p_2_1_2_01.rs

@@ -61,7 +61,7 @@ fn model(app: &App) -> Model {
     }
 }
 
-fn view(app: &App, model: &Model, frame: &Frame) {
+fn view(app: &App, model: &Model, frame: Frame) {
     let draw = app.draw();
     let win = app.window_rect();
 

examples/generative_design/shape/p_2_1_2_02.rs

@@ -77,7 +77,7 @@ fn model(app: &App) -> Model {
     }
 }
 
-fn view(app: &App, model: &Model, frame: &Frame) {
+fn view(app: &App, model: &Model, frame: Frame) {
     let draw = app.draw();
     let win = app.window_rect();
 

examples/generative_design/shape/p_2_1_2_03.rs

@@ -50,7 +50,7 @@ fn model(app: &App) -> Model {
     }
 }
 
-fn view(app: &App, model: &Model, frame: &Frame) {
+fn view(app: &App, model: &Model, frame: Frame) {
     let draw = app.draw();
     let win = app.window_rect();
 

examples/generative_design/shape/p_2_1_2_04.rs

@@ -59,7 +59,7 @@ fn model(app: &App) -> Model {
     }
 }
 
-fn view(app: &App, model: &Model, frame: &Frame) {
+fn view(app: &App, model: &Model, frame: Frame) {
     let draw = app.draw();
     let win = app.window_rect();
 

examples/laser/laser_frame_stream.rs

@@ -155,6 +155,6 @@ fn key_pressed(_app: &App, model: &mut Model, key: Key) {
         .unwrap();
 }
 
-fn view(_app: &App, _model: &Model, frame: &Frame) {
+fn view(_app: &App, _model: &Model, frame: Frame) {
     frame.clear(DIMGRAY);
 }

examples/laser/laser_frame_stream_gui.rs

@@ -568,6 +568,6 @@ fn key_pressed(_app: &App, model: &mut Model, key: Key) {
     }
 }
 
-fn view(app: &App, model: &Model, frame: &Frame) {
+fn view(app: &App, model: &Model, frame: Frame) {
     model.ui.draw_to_frame_if_changed(app, &frame).unwrap();
 }

examples/laser/laser_raw_stream.rs

@@ -76,7 +76,7 @@ fn mouse_moved(app: &App, model: &mut Model, pos: Point2) {
         .unwrap();
 }
 
-fn view(app: &App, _model: &Model, frame: &Frame) {
+fn view(app: &App, _model: &Model, frame: Frame) {
     // Visualise the point in the window.
     let draw = app.draw();
     draw.background().color(DIMGRAY);

examples/loop_mode.rs

@@ -48,6 +48,6 @@ fn key_pressed(app: &App, _model: &mut Model, _key: Key) {
     app.main_window().set_title(&title);
 }
 
-fn view(_app: &App, _model: &Model, frame: &Frame) {
+fn view(_app: &App, _model: &Model, frame: Frame) {
     frame.clear(DIMGRAY);
 }

examples/multi_window.rs

@@ -46,7 +46,7 @@ fn event_c(_app: &App, _model: &mut Model, event: WindowEvent) {
     println!("window c: {:?}", event);
 }
 
-fn view(_app: &App, model: &Model, frame: &Frame) {
+fn view(_app: &App, model: &Model, frame: Frame) {
     match frame.window_id() {
         id if id == model.a => frame.clear(INDIANRED),
         id if id == model.b => frame.clear(LIGHTGREEN),

examples/multi_window_draw.rs

@@ -46,7 +46,7 @@ fn event_c(_app: &App, _model: &mut Model, event: WindowEvent) {
     println!("window c: {:?}", event);
 }
 
-fn view(app: &App, model: &Model, frame: &Frame) {
+fn view(app: &App, model: &Model, frame: Frame) {
     let draw = app.draw_for_window(frame.window_id()).unwrap();
     match frame.window_id() {
         id if id == model.a => {
@@ -63,5 +63,5 @@ fn view(app: &App, model: &Model, frame: &Frame) {
         }
         _ => (),
     }
-    draw.to_frame(app, frame).unwrap();
+    draw.to_frame(app, &frame).unwrap();
 }

examples/named_color_reference.rs

@@ -81,7 +81,7 @@ fn update(app: &App, model: &mut Model, _update: Update) {
 }
 
 // Draw the state of your `Model` into the given `Frame` here.
-fn view(app: &App, model: &Model, frame: &Frame) {
+fn view(app: &App, model: &Model, frame: Frame) {
     let draw = app.draw();
 
     // Draw the background with the color.

examples/nature_of_code/chp_01_vectors/1_10_motion101_acceleration.rs

@@ -69,7 +69,7 @@ fn update(app: &App, m: &mut Model, _update: Update) {
     m.mover.update(pt2(app.mouse.x, app.mouse.y));
 }
 
-fn view(app: &App, m: &Model, frame: &Frame) {
+fn view(app: &App, m: &Model, frame: Frame) {
     // Begin drawing
     let draw = app.draw();
     draw.background().color(WHITE);

examples/nature_of_code/chp_01_vectors/1_11_motion101_acceleration_array.rs

@@ -84,7 +84,7 @@ fn update(app: &App, m: &mut Model, _update: Update) {
     }
 }
 
-fn view(app: &App, m: &Model, frame: &Frame) {
+fn view(app: &App, m: &Model, frame: Frame) {
     // Begin drawing
     let draw = app.draw();
     draw.background().color(WHITE);

examples/nature_of_code/chp_01_vectors/1_1_bouncingball_novectors.rs

@@ -46,7 +46,7 @@ fn update(app: &App, model: &mut Model, _update: Update) {
     }
 }
 
-fn view(app: &App, model: &Model, frame: &Frame) {
+fn view(app: &App, model: &Model, frame: Frame) {
     // Begin drawing
     let draw = app.draw();
     draw.background().color(WHITE);