fix: validation mode doesnt not reset when reset is called on form state
#302
+16
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mayb3Nots
changed the title
reset is called on form
Mayb3Nots
changed the title
reset is called on formreset is called on form state
Mayb3Nots
changed the title
reset is called on form statereset is called on form state
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
validateis called and our validation mode isalwaysAfterFirstValidationwe will set the mode permanently toalwaysinternally.When
resetis called on a form state key the all subsequent text field validation gets called and all the will fail the validation since the field has been reset. This is not expected behavior. The validation mode should also be reset whenresetis called so everything is truly reset.