Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix onChanged being called on every controller update #202

Merged
merged 1 commit into from
Nov 27, 2024
Merged

Fix onChanged being called on every controller update #202

merged 1 commit into from
Nov 27, 2024

Conversation

helightdev
Copy link
Contributor

Fixes #201

nank1ro
nank1ro approved these changes Nov 27, 2024
View reviewed changes
Copy link
Owner

@nank1ro nank1ro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nank1ro nank1ro self-assigned this Nov 27, 2024
@nank1ro nank1ro added the bug Something isn't working label Nov 27, 2024
@nank1ro nank1ro merged commit c7c1d32 into nank1ro:main Nov 27, 2024
@helightdev helightdev deleted the slider-fix branch November 28, 2024 01:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nank1ro nank1ro nank1ro approved these changes

Assignees

@nank1ro nank1ro

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ShadSlider onChanged callback getting called on controller update
2 participants
@helightdev @nank1ro