Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix console.* causing incorrect test failures #3

Merged
merged 1 commit into from
Sep 10, 2015

Conversation

joeybaker
Copy link

Previously, using console.log anywhere would cause a test failure. This, correctly, shows it as a comment, and removes a call to a library that was never defined.

@skovhus
Copy link

skovhus commented Sep 10, 2015

👍 Please merge this

@namuol
Copy link
Owner

namuol commented Sep 10, 2015

Looks like a duplicate of #2 but I'm going to merge this one in since it removes some old cruft (that try/catch block).

CC @nowells

namuol added a commit that referenced this pull request Sep 10, 2015
Fix console.* causing incorrect test failures
@namuol namuol merged commit 2e5f171 into namuol:master Sep 10, 2015
@joeybaker
Copy link
Author

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants