Skip to content
This repository has been archived by the owner on Nov 1, 2021. It is now read-only.

The min requirement should be set to php 5.5.* #6

Closed
mwidmann opened this issue Feb 22, 2017 · 2 comments
Closed

The min requirement should be set to php 5.5.* #6

mwidmann opened this issue Feb 22, 2017 · 2 comments

Comments

@mwidmann
Copy link

Neither guzzlehttp nor symphony-resolver work on php 5.4 and therefore the library can't be used in php 5.4.

The first issue occurring is that ::class used in OptionsResolver.php is not available until php 5.5

HP Parse error: syntax error, unexpected 'finally' (T_STRING), expecting catch (T_CATCH) in ..../vendor/symfony/options-resolver/OptionsResolver.php on line 786
@namnv609
Copy link
Owner

@mwidmann Thanks for your feedback. I'll fix it in next few days 😃!

namnv609 added a commit that referenced this issue Jul 3, 2017
@namnv609
Fix issues #6, #7
2782d9c
namnv609 added a commit that referenced this issue Jul 3, 2017
@namnv609
Merge pull request #9 from namnv609/fix_some_issues
46d06ff 
Fix issues #6, #7
@namnv609 namnv609 mentioned this issue Jul 3, 2017
Closed
@namnv609
Copy link
Owner

namnv609 commented Jul 3, 2017 •
edited
Loading

This issue has been fixed!

Thank you for your contributing ❤️!

https://github.com/namnv609/php-onesignal-sdk/releases

@namnv609 namnv609 closed this as completed Jul 4, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mwidmann @namnv609