Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PCFF-1975] Emit "false" and "0" for bools and ints where appropriate. #94

Merged
merged 2 commits into from
Oct 16, 2018

Conversation

henryguillen
Copy link
Contributor

See grpc-ecosystem/grpc-gateway#233

This is coming to grpc-gateway-v2, but we need to accelerate this due to the fact that we need to be able to build a C# proxy that is JSON-compatible with the pb-go serializer used in the gateway.

This is a breaking change, but it is also more reasonable. See a similar change in a public fork of the gateway flw-cn/grpc-gateway@aa60176

  1. i'm not actually sure even if we merge this whether we can build a compatible C# implementation using Newtonsoft.Json serialization.
  2. we would probably want to make this an optional change for our gateways

But hell if I'm gonna build this myself.

@mhamrah mhamrah merged commit 788ecbb into master Oct 16, 2018
@mhamrah mhamrah deleted the PCFF-1975 branch October 16, 2018 18:52
mhamrah added a commit that referenced this pull request Oct 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants