Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for data attributes on buttons #308

Merged

Conversation

zeckdude
Copy link
Contributor

Regarding Issue #307, I have implemented the changes and it works great.

To reiterate, this is how it is implemented:

var sessionModal = new BootstrapDialog({
  title: 'Please provide details about the class',
  message: 'Hi there',
  buttons: [
  {
    id: 'delete-session-prompt-btn',
    label: 'Delete Class',
    cssClass: 'btn-danger pull-left hidden',
    data: {
      'js': 'delete-btn',
      'ui': 'something'
    }
  },
});

This results in data-js="delete-btn" and data-ui="something" on the button element.

@nakupanda nakupanda merged commit 6199722 into nakupanda:master Oct 27, 2016
@nakupanda
Copy link
Owner

Merged, thanks for the implementation!

@nakupanda
Copy link
Owner

Please also create an example in the example page, if possible, thanks :)

nakupanda added a commit that referenced this pull request Oct 27, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants