Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solver for the BTE in highly symmetric nanostructures #141

Merged
merged 3 commits into from
May 25, 2024
Merged

Conversation

mrm24
Copy link
Contributor

@mrm24 mrm24 commented May 23, 2024

I modified few files to generalize few procedures so they can be used in both bulk and nano.
The main changes are in bte_nano, which is almost a "copy" of the bte.f90; also I removed magnetic field from there.
I've also corrected a bug, as the tensors where not properly dumped into the drag files for the iteration 0.

@nakib
Copy link
Owner

nakib commented May 25, 2024

Dear Marti,

Thanks for the pull request. Can you check if you have added the new source file that contains the bte_nano_module? The CI broke with the following error:

<ERROR> *cmd_build* Target error: Unable to find source for module dependency: "bte_nano_module" used by "app/elphbolt.f90"

@mrm24
Copy link
Contributor Author

mrm24 commented May 25, 2024

Yep, my fault I forgot to "git add" the new file. Now it should compile.

@nakib nakib merged commit e898838 into nakib:nano May 25, 2024
1 check passed
@nakib
Copy link
Owner

nakib commented May 25, 2024

Now all tests pass. Merged it just now. I'll get in touch regarding creating a test (suite) for the nano-stuff.

Thanks a bunch for this important contribution!

Best,
Nakib

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants