Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: recreate with kubebuilder go/v4 plugin #260

Merged
merged 7 commits into from
Sep 16, 2023

Conversation

nakamasato
Copy link
Owner

@nakamasato nakamasato commented Sep 10, 2023

what

Migration from go/v3 to go/v4

why

To make the code dependencies up-to-date

Ref

https://book.kubebuilder.io/plugins/go-v4-plugin

@codecov
Copy link

codecov bot commented Sep 10, 2023

Codecov Report

Merging #260 (beca658) into main (3594bd9) will decrease coverage by 0.75%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #260      +/-   ##
==========================================
- Coverage   62.18%   61.43%   -0.75%     
==========================================
  Files           6        6              
  Lines         669      669              
==========================================
- Hits          416      411       -5     
- Misses        203      207       +4     
- Partials       50       51       +1     
Files Changed Coverage Δ
internal/controller/mysql_controller.go 54.34% <ø> (-2.72%) ⬇️
internal/controller/mysqldb_controller.go 36.88% <ø> (ø)
internal/controller/mysqluser_controller.go 69.03% <ø> (ø)

@nakamasato nakamasato marked this pull request as ready for review September 16, 2023 11:58
@nakamasato nakamasato changed the title refactor: recreate with kubebuilder refactor: recreate with kubebuilder go/v4 plugin Sep 16, 2023
@nakamasato nakamasato merged commit f12a192 into main Sep 16, 2023
@nakamasato nakamasato deleted the recreate-with-kubebuilder branch September 16, 2023 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant