RTL support #1
Merged
RTL support #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I had a look today at the chart component and looks like it doesn't require any changes (RTL support should be done through Recharts lib rather than shadcn). And the Sidebar component is missing since this repo is behind in commits. Can you please sync the repo if you have some time so that I can continue? And this PR should be ready now for review. |
|
Thanks for the great work. I never got notified about this pull request so thanks for the mention. |
|
I just synced the fork. @jjeem |
|
Thank you. I'll try to finish it as soon as I can |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add RTL support for components: