Add flush-on-exit feature #81
Conversation
|
Not sure how much sense it makes to merge this right now, given that it probably doesn’t work anyway (and also, I have concerns about how well this works in context of feature unification…) That said, even if we do not land the crate feature, we can at least inform cargo that it should rebuild the crate if the |
Yeah, lemme fix shutdown first and then I think this should go in just on the principle that we should be mirroring all tracy flags. |
|
@nagisa This should be ready to go now! |
tracy-client-sys/Cargo.toml
Outdated
| @@ -43,6 +43,7 @@ ondemand = [] | |||
| manual-lifetime = ["delayed-init"] | |||
| delayed-init = [] | |||
| callstack-inlines = [] | |||
| exit = [] | |||
There was a problem hiding this comment.
It should be a default feature in all crates IMO. Using this won't be an epitome of convenience, but we can't make random configurations of this crate just hang without intentional action by the user.
There was a problem hiding this comment.
Fair enough, though that's definitely going to be annoying because now users need to disable default features. I wonder if no-exit does actually make more sense?
There was a problem hiding this comment.
I guess it could if one interprets it more like hold-on-exit, thus making it properly additive, rather than conceptually removing code that exits programs (which what the no-exit name suggests) :)
There was a problem hiding this comment.
That works! I went with flush-on-exit because hold makes it sound like we'll wait forever.
There was a problem hiding this comment.
Mmmm, that makes CI ugly unfortunately.
Signed-off-by: Alex Saveau <saveau.alexandre@gmail.com>
No description provided.