Add support for custom demanglers #119
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DaniPopes
force-pushed
the
custom-demangler
branch
from
5257794
to
3665595
Compare
nagisa
reviewed
Sep 18, 2024
| // > It is expected that it will be internally reused. | ||
| // > When a call to ___tracy_demangle is made, previous contents of the string memory | ||
| // > do not need to be preserved. | ||
| static mut BUFFER: Buffer = Buffer::new(); |
There was a problem hiding this comment.
This won't work right in MT contexts, will it? Don't we need at least a buffer for each thread?
There was a problem hiding this comment.
Don't think it has to be MT-safe, the cpp implementation uses a global malloc'd pointer that's reused like we do here and it's worked fine
| @@ -44,6 +44,9 @@ mod plot; | |||
| mod span; | |||
| mod state; | |||
|
|
|||
| #[cfg(feature = "demangle")] | |||
| pub mod demangle; | |||
There was a problem hiding this comment.
I would also pub use crate::demangle::register_demangler (see a similar thing done with frame above.)
There was a problem hiding this comment.
It's already exported through macro_export, do you want to do this regardless?
Co-authored-by: Simonas Kazlauskas <github@kazlauskas.me>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for custom demangler functions with the signature
fn(&str, &mut Buffer) -> std::fmt::ResultwhereBufferis an opaque type that only exposes an implementation ofstd::fmt::Write.The default implementation is moved to a standalone function, and the buffer is now cleared before any demangling is done as tracy guarantees:
Follow-up to #102.