Fix refresh listen #789
Open
Fix refresh listen #789
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add rpc reconnect chan
executeConfigListen when rpc client reconnect
|
|
|
当网络出现异常，例如客户端和服务端网络中断2分钟，期间服务端配置发生变更，在网络恢复之后，客户端并没有及时发送ConfigBatchListenRequest，导致客户端配置会出现分钟级的延迟 |
binbin0325
requested changes
Jan 21, 2025
| @@ -448,6 +449,7 @@ func (r *RpcClient) reconnect(serverInfo ServerInfo, onRequestFail bool) { | |||
| r.currentConnection = connectionNew | |||
| atomic.StoreInt32((*int32)(&r.rpcClientStatus), (int32)(RUNNING)) | |||
| r.notifyConnectionChange(CONNECTED) | |||
| ReconnectionChan <- struct{}{} | |||
There was a problem hiding this comment.
也许不需要ReconnectionChan，可以看下在notifyConnectionChange中实现IConnectionEventListener接口。
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
executeConfigListen when rpc client reconnect