Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX #716] fix the monitor in naming_grpc_proxy. #717

Merged
merged 1 commit into from
Jan 26, 2024

Conversation

brotherlu-xcq
Copy link
Contributor

replace the config monitor with naming monitor in naming_grpc_proxy.

@CLAassistant
Copy link

CLAassistant commented Jan 24, 2024

CLA assistant check
All committers have signed the CLA.

@codecov-commenter
Copy link

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (89c5ab6) 32.69% compared to head (fffaaee) 32.63%.

❗ Current head fffaaee differs from pull request most recent head ab085b0. Consider uploading reports for the commit ab085b0 to get more accurate results

Files Patch % Lines
...nts/naming_client/naming_grpc/naming_grpc_proxy.go 0.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #717      +/-   ##
==========================================
- Coverage   32.69%   32.63%   -0.07%     
==========================================
  Files          45       45              
  Lines        3294     3294              
==========================================
- Hits         1077     1075       -2     
- Misses       2136     2138       +2     
  Partials       81       81              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@binbin0325 binbin0325 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@binbin0325 binbin0325 merged commit 389f6b6 into nacos-group:master Jan 26, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants