Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: repair for updateCacheWhenEmpty not working #696

Merged
merged 1 commit into from
Dec 12, 2023

Conversation

lixiangwuxian
Copy link
Contributor

修复不起作用的updateCacheWhenEmpty配置

@lixiangwuxian
Copy link
Contributor Author

#695

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5fedf57) 29.77% compared to head (c545ce9) 29.67%.

❗ Current head c545ce9 differs from pull request most recent head eb5d6aa. Consider uploading reports for the commit eb5d6aa to get more accurate results

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #696      +/-   ##
==========================================
- Coverage   29.77%   29.67%   -0.10%     
==========================================
  Files          40       40              
  Lines        3147     3144       -3     
==========================================
- Hits          937      933       -4     
  Misses       2139     2139              
- Partials       71       72       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@binbin0325 binbin0325 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@binbin0325 binbin0325 merged commit 65e2c9d into nacos-group:master Dec 12, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants