Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: export ServerHealthy in INamingClient #677

Merged
merged 1 commit into from
Nov 8, 2023
Merged

feat: export ServerHealthy in INamingClient #677

merged 1 commit into from
Nov 8, 2023

Conversation

lixiangwuxian
Copy link
Contributor

@lixiangwuxian lixiangwuxian commented Nov 6, 2023

INamingClient 接口提供 ServerHealthy() bool 方法,便于无副作用的进行nacos服务可用性检查 fix:#676

@CLAassistant
Copy link

CLAassistant commented Nov 6, 2023

CLA assistant check
All committers have signed the CLA.

@codecov-commenter
Copy link

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (4eb0559) 29.71% compared to head (b60e9ae) 29.82%.

❗ Current head b60e9ae differs from pull request most recent head cd60601. Consider uploading reports for the commit cd60601 to get more accurate results

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #677      +/-   ##
==========================================
+ Coverage   29.71%   29.82%   +0.11%     
==========================================
  Files          40       40              
  Lines        3093     3095       +2     
==========================================
+ Hits          919      923       +4     
+ Misses       2104     2103       -1     
+ Partials       70       69       -1     
Files Coverage Δ
clients/naming_client/naming_client.go 34.32% <0.00%> (-0.35%) ⬇️

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@binbin0325 binbin0325 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@binbin0325 binbin0325 merged commit 6930f82 into nacos-group:master Nov 8, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants