Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

调整 [INFO] logDir cacheDir 日志输出 #590

Merged
merged 4 commits into from
Mar 23, 2023

Conversation

Cotch22
Copy link
Contributor

@Cotch22 Cotch22 commented Mar 16, 2023

#260

这个问题曾经被提到过,但是在一次次更变中又被改了回去。

go 的默认 log 是 StdErr 通道的,这条日志打印对日志收集器存在影响。

现在改为 日志等级为 info 时才打印,并且打印到 StdOut标准输出。

@binbin0325
Copy link
Member

#260

这个问题曾经被提到过,但是在一次次更变中又被改了回去。

go 的默认 log 是 StdErr 通道的,这条日志打印对日志收集器存在影响。

现在改为 日志等级为 info 时才打印,并且打印到 StdOut标准输出。

存在的影响是什么?可以具体一点吗?

@Cotch22
Copy link
Contributor Author

Cotch22 commented Mar 16, 2023

#260
这个问题曾经被提到过,但是在一次次更变中又被改了回去。
go 的默认 log 是 StdErr 通道的,这条日志打印对日志收集器存在影响。
现在改为 日志等级为 info 时才打印,并且打印到 StdOut标准输出。

存在的影响是什么?可以具体一点吗?

很简单,因为 log 默认输出到了 StdErr,会被日志采集器采集,我们一些任务脚本会检测到标准错误输出,然后给任务标记为出错

@Cotch22 Cotch22 requested a review from binbin0325 March 16, 2023 13:35
@Cotch22 Cotch22 requested a review from binbin0325 March 18, 2023 06:49
@Cotch22
Copy link
Contributor Author

Cotch22 commented Mar 22, 2023

@binbin0325
本地跑单测是过的,-v 输出和 CI 一样,CI 的 143 貌似是因为手动停止,要不重跑一遍。
image

@codecov-commenter
Copy link

Codecov Report

Patch coverage has no change and project coverage change: -0.07 ⚠️

Comparison is base (73c4f36) 30.70% compared to head (e8f01c5) 30.63%.

❗ Current head e8f01c5 differs from pull request most recent head ad24b0c. Consider uploading reports for the commit ad24b0c to get more accurate results

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #590      +/-   ##
==========================================
- Coverage   30.70%   30.63%   -0.07%     
==========================================
  Files          40       40              
  Lines        3042     3042              
==========================================
- Hits          934      932       -2     
- Misses       2042     2043       +1     
- Partials       66       67       +1     

see 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@binbin0325 binbin0325 merged commit 43cf5ae into nacos-group:master Mar 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants