Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix MaxInt64 overflows on ARM 32-bits #575

Merged
merged 3 commits into from
Feb 21, 2023
Merged

Fix MaxInt64 overflows on ARM 32-bits #575

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6645b94
Fix MaxInt64 overflows on ARM 32-bits
Feb 16, 2023
54d0813
use Math.MaxInt to avoid overflows on ARM 32-bits
Feb 17, 2023
b0c7c5e
change to Math.MaxInt32 because MaxInt is only supported in golang 1.17
Feb 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion clients/config_client/config_client.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,7 +138,8 @@ func NewConfigClient(nc nacos_client.INacosClient) (*ConfigClient, error) {

config.cacheMap = cache.NewConcurrentMap()
// maximum buffered queue to prevent chan deadlocks during frequent configuration file updates
config.listenExecute = make(chan struct{}, math.MaxInt64)
rayae marked this conversation as resolved.
Show resolved Hide resolved
// use Math.MaxInt32 to avoid overflows on ARM 32-bits
config.listenExecute = make(chan struct{}, math.MaxInt32)

config.startInternal()

Expand Down