Import whole of multiline comments (#9)

nacnudus · Feb 13, 2017 · 96df3bd · 96df3bd
1 parent 2dcf48e
commit 96df3bd
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/src/xlsxsheet.cpp b/src/xlsxsheet.cpp
@@ -173,7 +173,7 @@ void xlsxsheet::cacheComments(Rcpp::String comments_path) {
     for (rapidxml::xml_node<>* comment = commentList->first_node();
         comment; comment = comment->next_sibling()) {
       std::string ref(comment->first_attribute("ref")->value());
-      rapidxml::xml_node<>* r = comment->first_node()->first_node();
+      rapidxml::xml_node<>* r = comment->first_node();
       // Get the inline string
       std::string inlineString;
       parseString(r, inlineString); // value is modified in place

diff --git a/tests/testthat/test-comments.R b/tests/testthat/test-comments.R
@@ -0,0 +1,6 @@
+context("Comments")
+
+test_that("multiline comments are returned in full", {
+  expect_equal(tidy_xlsx("examples.xlsx")$data$Sheet1$comment[19],
+               "commentwithtextformatting")
+})