Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for brainpool curves #91

Closed
dzabel opened this issue May 5, 2022 · 1 comment
Closed

Add support for brainpool curves #91

dzabel opened this issue May 5, 2022 · 1 comment

Comments

@dzabel
Copy link

dzabel commented May 5, 2022

To avoid stacktrace in sslyze check --tlsv1_2 when using a server that supports brainpool curves, these should be added to nassl.

sample error:

 * Error when running --tlsv1_2:
       You can open an issue at https://github.com/nabla-c0d3/sslyze/issues with the following information:

       * SSLyze version: 5.0.4
       * Server: 127.0.0.1:443 - 127.0.0.1
       * Scan command: tls_1_2_cipher_suites

       Traceback (most recent call last):
         File "/sslyze/sslyze/scanner/_mass_scanner.py", line 267, in _generate_result_for_completed_server_scan
    scan_cmd_result = plugin_implementation_cls.result_for_completed_scan_jobs(
         File "/sslyze/sslyze/plugins/openssl_cipher_suites/implementation.py", line 124, in result_for_completed_scan_jobs
    cipher_suite_result = completed_job.get_result()
         File "/sslyze/sslyze/plugins/plugin_base.py", line 61, in get_result
    raise self._exception
         File "/sslyze/sslyze/scanner/_jobs_worker_thread.py", line 50, in run
    return_value = job_to_complete.function_to_call(*job_to_complete.function_arguments)
         File "/sslyze/sslyze/plugins/openssl_cipher_suites/_test_cipher_suite.py", line 55, in connect_with_cipher_suite
    ephemeral_key = ssl_connection.ssl_client.get_ephemeral_key()
         File "/usr/local/lib/python3.9/site-packages/nassl-4.0.2-py3.9-linux-x86_64.egg/nassl/ssl_client.py", line 326, in get_ephemeral_key
    return NistEcDhKeyExchangeInfo(**dh_info)
         File "<string>", line 9, in __init__
         File "/usr/local/lib/python3.9/site-packages/nassl-4.0.2-py3.9-linux-x86_64.egg/nassl/ephemeral_key_info.py", line 123, in __post_init__
    curve_name = f"unknown-curve-with-openssl-id-{self.curve.value}"
       AttributeError: 'int' object has no attribute 'value'

releated issue sslyze:
nabla-c0d3/sslyze#545

there was already an attempt to support brainpool curves:
4944226

but was reverted (no matter why):
a7e0fdb

@nabla-c0d3 nabla-c0d3 moved this to Todo in SSLyze 5.1.0 Nov 6, 2022
@nabla-c0d3 nabla-c0d3 moved this from Todo to Done in SSLyze 5.1.0 Nov 20, 2022
@nabla-c0d3
Copy link
Owner

Fix released as part of v5.0.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Done
Development

No branches or pull requests

2 participants