Add S2 Geometry classes to Poke-API #28
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
Not a lot of ruby devs on the discord so throwing it out there that I can check this over tomorrow (btw Id consider making this its own gem, even thought it not full s2(neither is s2phere) but not required). |
|
Yeah could do that I suppose, though it will lack a lot of functionality in general for anyone wanting to use it outside the scope of Pokemon GO (which is why I added it in the the gem itself). |
|
Well maybe if theres a wider demand people would be more likely to contribute outside of pogo. Just a thought. Call it an unfinished port or something |
|
Sounds good, I'll create its own repository tomorrow. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If anyone can have a double check over this before I merge it in then that'd be greatly appreciated!
This fixes #2