Create the correct version of the Elasticsearch client #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Elasticsearch changed the way how to create the client between version 1 and 2. We should handle both cases to be independent from the version.
|
Hm yes that's true, but why keep supporting v1 ? Wouldn't it be better to make people upgrade to version 2 ? |
|
I have no idea how long version 2 of ES is out and if version 1 is still supported. So I thought a graceperiod would be nice. Next version will support both, next version + 1 removes the support for ES 1. Furthermore my first PR has a bug. I forgot to import the ClientBuilder. |
|
Sorry for the late reply, read your reply during work and forgot to come back to it afterwards. 😄 |
nWidart
added a commit
that referenced
this pull request
Mar 8, 2016
Create the correct version of the Elasticsearch client
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Elasticsearch changed the way how to create the client between version 1
and 2. We should handle both cases to be independent from the version.