Skip to content

Conversation

@github-actions

This comment has been minimized.

@github-actions
Copy link

Unit Test Results

       5 files     111 suites   24s ⏱️
1 131 tests 1 054 ✔️ 77 💤 0 ❌
2 096 runs  2 014 ✔️ 82 💤 0 ❌

Results for commit 8cf9cf5.

Copy link
Member

@milkshakeuk milkshakeuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@PhantomGrazzler are these all static code analysis changes? Are we sure these fields only get set at construction time?

@PhantomGrazzler
Copy link
Contributor Author

@PhantomGrazzler are these all static code analysis changes? Are we sure these fields only get set at construction time?

Yes, these are all static analysis changes that I saw on Codacy (https://app.codacy.com/gh/nHapiNET/nHapi/pullRequest?prid=9304251).

My understanding of the readonly keyword (https://docs.microsoft.com/en-us/dotnet/csharp/language-reference/keywords/readonly) is that the code would fail to compile if there is an attempt to assign to these fields outside of constructor or field declaration. It is entirely possible that my understanding is flawed though :)

@milkshakeuk
Copy link
Member

@PhantomGrazzler okay cool, makes sense.

@milkshakeuk milkshakeuk merged commit da26e97 into nHapiNET:master Apr 25, 2022
@milkshakeuk
Copy link
Member

@PhantomGrazzler thanks for the PR.

@milkshakeuk milkshakeuk added this to the v3.2.0 milestone Jan 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants