Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Credential testing for sharees #9426

Merged
merged 3 commits into from
May 17, 2024
Merged

fix: Credential testing for sharees #9426

merged 3 commits into from
May 17, 2024

Conversation

krynble
Copy link
Contributor

@krynble krynble commented May 16, 2024 •
edited by despairblue
Loading

Summary

Fix the credential testing for credentials that were shared.

Review / Merge checklist

  • PR title and summary are descriptive. Remember, the title automatically goes into the changelog. Use (no-changelog) otherwise. (conventions)
  • Docs updated or follow-up ticket created.
  • Tests included.

@krynble krynble requested a review from a team as a code owner May 16, 2024 13:23
@krynble krynble changed the base branch from master to feature/rbac May 16, 2024 13:23
@krynble krynble marked this pull request as draft May 16, 2024 13:23
@n8n-assistant n8n-assistant bot added core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team labels May 16, 2024
@krynble krynble changed the title Fix credentialtest fix: Credential testing for sharees May 16, 2024
@krynble krynble marked this pull request as ready for review May 16, 2024 16:14
@cypress Cypress
Copy link

cypress bot commented May 17, 2024

Passing run #5001 ↗︎

0 361 12 0 Flakiness 0

Details:

🌳 🖥️ browsers:node18.12.0-chrome107 🤖 krynble 🗃️ e2e/*
Project: n8n Commit: 5102b89344
Status: Passed Duration: 04:18 💡
Started: May 17, 2024 7:57 AM Ended: May 17, 2024 8:01 AM

Review all test suite changes for PR #9426 ↗︎

@github-actions GitHub Actions
Copy link
Contributor

✅ All Cypress E2E specs passed

@despairblue
Copy link
Contributor

LGTM

@krynble krynble merged commit 14b2b0f into feature/rbac May 17, 2024
8 checks passed
@krynble krynble deleted the fix-credentialtest branch May 17, 2024 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@despairblue despairblue despairblue approved these changes

Assignees
No one assigned
Labels
core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@krynble @despairblue