Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(editor): Fix failing sharing e2e tests partially #9417

Merged
merged 1 commit into from
May 15, 2024

Conversation

despairblue
Copy link
Contributor

Summary

This updates the selectors and urls the tests have been using to work with the new sharing components and the new home section.

Related tickets and issues

none

Review / Merge checklist

  • PR title and summary are descriptive. Remember, the title automatically goes into the changelog. Use (no-changelog) otherwise. (conventions)
  • Tests included.

    A bug is not considered fixed, unless a test is added to prevent it from happening again.
    A feature is not complete without tests.

@despairblue despairblue marked this pull request as ready for review May 15, 2024 18:52
@n8n-assistant n8n-assistant bot added the n8n team Authored by the n8n team label May 15, 2024
Copy link
Contributor

⚠️ Some Cypress E2E specs are failing, please fix them before merging

Copy link

cypress bot commented May 15, 2024

3 failed tests on run #4978 ↗︎

3 358 12 0 Flakiness 0

Details:

🌳 🖥️ browsers:node18.12.0-chrome107 🤖 despairblue 🗃️ e2e/*
Project: n8n Commit: 5565419b8c
Status: Failed Duration: 04:19 💡
Started: May 15, 2024 7:10 PM Ended: May 15, 2024 7:14 PM
Failed  cypress/e2e/17-sharing.cy.ts • 3 failed tests

View Output Video

Test Artifacts
Sharing > should open W1, add node using C2 as U2 Test Replay Screenshots Video
Sharing > should automatically test C2 when opened by U2 sharee Test Replay Screenshots Video
Sharing > should work for admin role on credentials created by others (also can share it with themselves) Test Replay Screenshots Video

Review all test suite changes for PR #9417 ↗︎

@despairblue despairblue merged commit 681c2bf into feature/rbac May 15, 2024
25 of 28 checks passed
@despairblue despairblue deleted the partially-fix-sharing-e2e-test branch May 15, 2024 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants