fix: ProjectRepository.getPersonalProjectForUser[OrFail] not taking the type or the role of the user to the project into account #8676
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
despairblue
commented
Feb 20, 2024
packages/cli/test/integration/database/repositories/project.repository.test.ts
Outdated
Show resolved
Hide resolved
It was not taking the type of the project and the role the user has to the project into account.
despairblue
force-pushed
the
fix-project-repo-get-personal-project-for-user
branch
from
a278f59
to
a41aba2
Compare
valya
approved these changes
Feb 20, 2024
|
✅ All Cypress E2E specs passed |
1 flaky test on run #4149 ↗︎
Details:
|
|||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| NDV > should not retrieve remote options when required params throw errors |
Test Replay
Screenshots
Video
|
|
Review all test suite changes for PR #8676 ↗︎
n8n-assistant
bot
added
core
despairblue
deleted the
fix-project-repo-get-personal-project-for-user
branch
cstuncsik
pushed a commit
that referenced
this pull request
Feb 21, 2024
…he type or the role of the user to the project into account (#8676)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Before
ProjectRepository.getPersonalProjectForUserdid not take into account the type of the project or the user's role in the project and thus may return team or public projects.Related tickets and issues
none
Review / Merge checklist
(no-changelog)otherwise. (conventions)