feat(core): Allow creating workflows in other projects than the personal one #8662
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
despairblue
force-pushed
the
create-workflow-in-project
branch
from
179e15e
to
6bafdef
Compare
despairblue
commented
Feb 16, 2024
krynble
reviewed
Feb 19, 2024
despairblue
force-pushed
the
create-workflow-in-project
branch
from
86cd56b
to
2a6da18
Compare
using the repo is easy enough
that way it get's reported to sentry
despairblue
force-pushed
the
create-workflow-in-project
branch
from
ec8591d
to
7985ed6
Compare
despairblue
commented
Feb 20, 2024
valya
requested changes
Feb 21, 2024
valya
approved these changes
Feb 21, 2024
2 flaky tests on run #4183 ↗︎
Details:
|
|||||||||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| NDV > should not retrieve remote options when required params throw errors |
Test Replay
Screenshots
Video
|
|
24-ndv-paired-item.cy.ts • 1 flaky test
| Test | Artifacts | |
|---|---|---|
| NDV > resolves expression with default item when input node is not parent, while still pairing items |
Test Replay
Screenshots
Video
|
|
Review all test suite changes for PR #8662 ↗︎
|
✅ All Cypress E2E specs passed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This allow calling
POST /workflowswithprojectIdin the body.If the field is not there, the workflow will be shared with the user's personal project.
If the field is there, the workflow will be shared with that project, if the user has the permissions to do so. Otherwise the request will fail with a 400 status code.
Related tickets and issues
There is no linear ticket for this as far as I know.
Review / Merge checklist
(no-changelog)otherwise. (conventions)