fix(HTTP Request Node): Handle special characters in pagination expressions + improve hint text #8576
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…node-name-makes-pagination
elsmr
changed the title
n8n-assistant
bot
added
core
3 tasks
…http-request-node-apostrophe-in-node-name-makes-pagination
| throw new NodeOperationError(node, `'${paginateRequestData.url}' is not a valid URL.`, { | ||
| itemIndex, | ||
| runIndex, | ||
| type: 'invalid_url', |
There was a problem hiding this comment.
I would avoid extending NodeApiError interface for this special case, as this error would be replaced in Http node anyway we could send some technical message for identification
There was a problem hiding this comment.
I prefer using a type to check on instead of using the message. We also use this pattern for other errors (like ExpressionError)
…node-name-makes-pagination
michael-radency
approved these changes
Feb 12, 2024
1 flaky test on run #4083 ↗︎
Details:
|
|||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| NDV > should not retrieve remote options when required params throw errors |
Test Replay
Screenshots
Video
|
|
Review all test suite changes for PR #8576 ↗︎
|
✅ All Cypress E2E specs passed |
elsmr
deleted the
node-1097-http-request-node-apostrophe-in-node-name-makes-pagination
branch
Merged
|
Got released with |
despairblue
pushed a commit
that referenced
this pull request
Feb 16, 2024
…ssions + improve hint text (#8576) Co-authored-by: Michael Kret <michael.k@radency.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Related tickets and issues
https://linear.app/n8n/issue/NODE-1097/http-request-node-apostrophe-in-node-name-makes-pagination-expressions
Review / Merge checklist
(no-changelog)otherwise. (conventions)