fix(core): Make sure that special polling parameters are available on community nodes as well #6230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… community nodes as well This broke in 0.227.0.
n8n-assistant
bot
added
core
|
Great PR! Please pay attention to the following items before merging: Files matching
Files matching
Make sure to check off this list before asking for review. |
Joffcom
approved these changes
May 11, 2023
|
✅ All Cypress E2E specs passed |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #6230 +/- ##
==========================================
+ Coverage 27.59% 27.62% +0.02%
==========================================
Files 2935 2938 +3
Lines 179761 179927 +166
Branches 19539 19543 +4
==========================================
+ Hits 49612 49707 +95
- Misses 129418 129489 +71
Partials 731 731
☔ View full report in Codecov by Sentry. |
MiloradFilipovic
added a commit
that referenced
this pull request
May 12, 2023
* master: feat(editor): Version Control settings update (WIP) (#6233) ci: Fix linting issue on master (no-changelog) (#6232) fix: Prevent type error messages for manual executions (no-changelog) (#6229) fix(Code Node): Restore help text (#6231) fix(core): Make sure that special polling parameters are available on community nodes as well (#6230) feat(editor): Add color picker design system component (#6179) feat(Google Ads Node): Update to support v13 (#6212) ci: Fix published nodes-base package's dependencies (no-changelog) (#6226) ci: Code coverage should include `.vue` files as well (no-changelog) (#6224) 🚀 Release 0.228.0 (#6219)
csuermann
pushed a commit
that referenced
this pull request
May 15, 2023
… community nodes as well (#6230) This broke in 0.227.0.
netroy
added a commit
that referenced
this pull request
May 15, 2023
… community nodes as well (#6230) This broke in 0.227.0.
|
Got released with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This broke in 0.227.0.