Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Kafka Trigger Node): Add non-parallel execution #6175

Merged
merged 5 commits into from
May 4, 2023
Merged
Changes from 3 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 33 additions & 7 deletions packages/nodes-base/nodes/Kafka/KafkaTrigger.node.ts
Original file line number Diff line number Diff line change
Expand Up @@ -9,16 +9,17 @@ import type {
INodeType,
INodeTypeDescription,
ITriggerResponse,
IRun,
} from 'n8n-workflow';
import { NodeOperationError } from 'n8n-workflow';
import { createDeferredPromise, NodeOperationError } from 'n8n-workflow';

export class KafkaTrigger implements INodeType {
description: INodeTypeDescription = {
displayName: 'Kafka Trigger',
name: 'kafkaTrigger',
icon: 'file:kafka.svg',
group: ['trigger'],
version: 1,
version: [1, 1.1],
description: 'Consume messages from a Kafka topic',
defaults: {
name: 'Kafka Trigger',
Expand Down Expand Up @@ -116,7 +117,7 @@ export class KafkaTrigger implements INodeType {
type: 'number',
default: 1,
description:
'Max number of requests that may be in progress at any time. If falsey then no limit.',
'Max number of requests that may be in progress at any time. If false then no limit.',
agobrech marked this conversation as resolved.
Show resolved Hide resolved
},
{
displayName: 'Read Messages From Beginning',
Expand All @@ -132,6 +133,19 @@ export class KafkaTrigger implements INodeType {
default: false,
description: 'Whether to try to parse the message to an object',
},
{
displayName: 'Parallel Processing',
name: 'parallelProcessing',
type: 'boolean',
default: true,
displayOptions: {
hide: {
'@version': [1],
},
},
description:
'Whether to process messages in parallel or by keeping the message in order',
},
{
displayName: 'Only Message',
name: 'onlyMessage',
Expand Down Expand Up @@ -177,6 +191,10 @@ export class KafkaTrigger implements INodeType {

const ssl = credentials.ssl as boolean;

const options = this.getNodeParameter('options', {}) as IDataObject;

options.nodeVersion = this.getNode().typeVersion;

const config: KafkaConfig = {
clientId,
brokers,
Expand Down Expand Up @@ -213,9 +231,9 @@ export class KafkaTrigger implements INodeType {
heartbeatInterval: this.getNodeParameter('options.heartbeatInterval', 3000) as number,
});

await consumer.connect();
const parallelProcessing = options.parallelProcessing as boolean;

const options = this.getNodeParameter('options', {}) as IDataObject;
await consumer.connect();

await consumer.subscribe({ topic, fromBeginning: options.fromBeginning ? true : false });

Expand Down Expand Up @@ -261,8 +279,16 @@ export class KafkaTrigger implements INodeType {
//@ts-ignore
data = value;
}

this.emit([this.helpers.returnJsonArray([data])]);
let responsePromise = undefined;
if (!parallelProcessing && (options.nodeVersion as number) > 1) {
responsePromise = await createDeferredPromise<IRun>();
this.emit([this.helpers.returnJsonArray([data])], undefined, responsePromise);
} else {
this.emit([this.helpers.returnJsonArray([data])]);
}
if (responsePromise) {
await responsePromise.promise();
}
},
});
};
Expand Down