Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(editor): Add infix to Pinia stores (no-changelog) #6149

Merged
merged 5 commits into from
May 5, 2023
Merged

refactor(editor): Add infix to Pinia stores (no-changelog) #6149

merged 5 commits into from
May 5, 2023

Conversation

ivov
Copy link
Contributor

@ivov ivov commented May 2, 2023

To improve poor searchability

@github-actions
Copy link
Contributor

github-actions bot commented May 2, 2023

Great PR! Please pay attention to the following items before merging:

Files matching packages/**:

  • If fixing bug, added test to cover scenario.
  • If addressing forum or Github issue, added link to description.

Files matching packages/**/*.ts:

  • Added unit tests to cover new or updated functionality.

Files matching **/*.vue:

  • Used composition API for all new components.
  • Added component or unit tests to cover functionality.

Files matching packages/editor-ui/**/*.vue:

  • Added E2E if adding new features.
  • Used design system tokens (colors, spacings...) where possible.

Make sure to check off this list before asking for review.

@n8n-assistant n8n-assistant bot added n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system labels May 2, 2023
@codecov
Copy link

codecov bot commented May 2, 2023 •
edited
Loading

Codecov Report

Patch coverage: 98.75% and no project coverage change.

Comparison is base (35c8510) 20.07% compared to head (0f8471e) 20.07%.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #6149   +/-   ##
=======================================
  Coverage   20.07%   20.07%           
=======================================
  Files        2627     2627           
  Lines      118204   118207    +3     
  Branches    18573    18572    -1     
=======================================
+ Hits        23724    23729    +5     
+ Misses      93761    93759    -2     
  Partials      719      719
Impacted Files Coverage Δ
packages/editor-ui/src/mixins/newVersions.ts 0.00% <0.00%> (ø)
packages/editor-ui/src/stores/history.store.ts 28.08% <ø> (ø)
packages/editor-ui/src/stores/nodeCreator.store.ts 88.46% <ø> (ø)
packages/editor-ui/src/stores/telemetry.store.ts 81.81% <ø> (ø)
...nts/CodeNodeEditor/completions/base.completions.ts 18.18% <100.00%> (ø)
...odeNodeEditor/completions/jsonField.completions.ts 22.39% <100.00%> (ø)
.../CodeNodeEditor/completions/require.completions.ts 30.43% <100.00%> (ø)
...ponents/Node/NodeCreator/composables/useActions.ts 27.52% <100.00%> (ø)
...ents/Node/NodeCreator/composables/useViewStacks.ts 94.14% <100.00%> (ø)
.../editor-ui/src/composables/useCanvasMouseSelect.ts 8.54% <100.00%> (ø)
... and 46 more

... and 4 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

netroy
netroy reviewed May 2, 2023
View reviewed changes
Copy link
Member

@netroy netroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we setup some linting rule to enforce such file names?
I'm certain that there are other places in the codebase that could use such a rule.

@ivov
Copy link
Contributor Author

ivov commented May 2, 2023

Can we setup some linting rule to enforce such file names? I'm certain that there are other places in the codebase that could use such a rule.

Something like this looks promising, using overrides to target specific directories. Ideally separately as this PR is large enough already.

@github-actions
Copy link
Contributor

github-actions bot commented May 5, 2023

✅ All Cypress E2E specs passed

@ivov ivov merged commit d5c4498 into master May 5, 2023
@ivov ivov deleted the add-infix-to-pinia-stores branch May 5, 2023 08:41
MiloradFilipovic added a commit that referenced this pull request May 5, 2023
@MiloradFilipovic
Merge branch 'master' into N8N-5677-refactor-workflows-store
4533c45 
* master:
  fix(FTP Node): Use filename instead of remote filepath for downloaded binary data (#6170)
  ci: Fix test database cleanup (no-changelog) (#6188)
  refactor(core): Delete boilerplate code across migrations (no-changelog) (#5254)
  refactor(editor): Add infix to Pinia stores (no-changelog) (#6149)
  ci: Fix linting issues on master (no-changelog) (#6186)
MiloradFilipovic added a commit that referenced this pull request May 9, 2023
@MiloradFilipovic
Merge branch 'master' into feature/resource-mapping-component
7ebbb28 
* master: (31 commits)
  feat(Date & Time Node): Overhaul of the node (#5904)
  refactor: Add deprecation notice for WEBHOOK_TUNNEL_URL (#6194)
  refactor: Add deprecation notice for WEBHOOK_TUNNEL_URL (#6194)
  feat(HubSpot Node): Overhaul the HubSpot Node (#4337)
  ci: Create a nightly v1 docker image (no-changelog) (#6197)
  refactor(core): Add deprecation notice for own mode (#6195)
  feat(core): Update config defaults for for v1 (no-changelog) (#6196)
  test(Read Binary Files Node): Unit tests (no-changelog) (#5459)
  refactor: Add deprecation notice for MySQL and MariaDB (#6189)
  test: Create custom jest error messages using jest-expect-message (no-changelog) (#5666)
  fix(core): Move nodeExecute InternalHook calls to hookFunctionsSave (#6193)
  fix(FTP Node): Use filename instead of remote filepath for downloaded binary data (#6170)
  ci: Fix test database cleanup (no-changelog) (#6188)
  refactor(core): Delete boilerplate code across migrations (no-changelog) (#5254)
  refactor(editor): Add infix to Pinia stores (no-changelog) (#6149)
  ci: Fix linting issues on master (no-changelog) (#6186)
  fix(editor): Update and add design system checkbox component to Editor (#6178)
  fix(editor): Display SSO entry in Settings on Cloud (#6181)
  feat(Code Node): Add Python support (#4295)
  fix(editor): Update and fix storybook (was failing to run in local dev mode) (#6180)
  ...

# Conflicts:
#	packages/editor-ui/src/stores/nodeTypes.store.ts
#	packages/nodes-base/nodes/Postgres/Postgres.node.ts
#	packages/nodes-base/nodes/Postgres/v2/actions/versionDescription.ts
MiloradFilipovic added a commit that referenced this pull request May 9, 2023
@MiloradFilipovic
Merge branch 'feature/resource-mapping-component' into NODE-398-resou…
34a9423 
…rce-mapper-ui-P2

* feature/resource-mapping-component: (31 commits)
  feat(Date & Time Node): Overhaul of the node (#5904)
  refactor: Add deprecation notice for WEBHOOK_TUNNEL_URL (#6194)
  refactor: Add deprecation notice for WEBHOOK_TUNNEL_URL (#6194)
  feat(HubSpot Node): Overhaul the HubSpot Node (#4337)
  ci: Create a nightly v1 docker image (no-changelog) (#6197)
  refactor(core): Add deprecation notice for own mode (#6195)
  feat(core): Update config defaults for for v1 (no-changelog) (#6196)
  test(Read Binary Files Node): Unit tests (no-changelog) (#5459)
  refactor: Add deprecation notice for MySQL and MariaDB (#6189)
  test: Create custom jest error messages using jest-expect-message (no-changelog) (#5666)
  fix(core): Move nodeExecute InternalHook calls to hookFunctionsSave (#6193)
  fix(FTP Node): Use filename instead of remote filepath for downloaded binary data (#6170)
  ci: Fix test database cleanup (no-changelog) (#6188)
  refactor(core): Delete boilerplate code across migrations (no-changelog) (#5254)
  refactor(editor): Add infix to Pinia stores (no-changelog) (#6149)
  ci: Fix linting issues on master (no-changelog) (#6186)
  fix(editor): Update and add design system checkbox component to Editor (#6178)
  fix(editor): Display SSO entry in Settings on Cloud (#6181)
  feat(Code Node): Add Python support (#4295)
  fix(editor): Update and fix storybook (was failing to run in local dev mode) (#6180)
  ...

# Conflicts:
#	packages/editor-ui/src/stores/nodeTypes.store.ts
@janober
Copy link
Member

janober commented May 25, 2023

Got released with n8n@0.228.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@netroy netroy netroy approved these changes

Assignees
No one assigned
Labels
n8n team Authored by the n8n team Released ui Enhancement in /editor-ui or /design-system
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ivov @janober @netroy