Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(HTTP Request Node): Add description for 'Specify Body' option #6114

Merged
merged 2 commits into from
Apr 27, 2023

Conversation

csuermann
Copy link
Contributor

No description provided.

@github-actions
Copy link
Contributor

Great PR! Please pay attention to the following items before merging:

Files matching packages/**:

  • If fixing bug, added test to cover scenario.
  • If addressing forum or Github issue, added link to description.

Files matching packages/**/*.ts:

  • Added unit tests to cover new or updated functionality.

Files matching packages/nodes-base/nodes/**:

  • Added workflow tests for nodes if possible.

Make sure to check off this list before asking for review.

ivov
ivov previously approved these changes Apr 27, 2023
@n8n-assistant n8n-assistant bot added n8n team Authored by the n8n team node/improvement New feature or request labels Apr 27, 2023
@github-actions
Copy link
Contributor

✅ All Cypress E2E specs passed

@codecov
Copy link

codecov bot commented Apr 27, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (c6e665a) 19.19% compared to head (82b6ace) 19.19%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #6114   +/-   ##
=======================================
  Coverage   19.19%   19.19%           
=======================================
  Files        2589     2589           
  Lines      116890   116890           
  Branches    18339    18339           
=======================================
  Hits        22439    22439           
  Misses      93806    93806           
  Partials      645      645           
Impacted Files Coverage Δ
...es-base/nodes/HttpRequest/V3/HttpRequestV3.node.ts 30.98% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@github-actions
Copy link
Contributor

✅ All Cypress E2E specs passed

@csuermann csuermann merged commit af097ae into master Apr 27, 2023
@csuermann csuermann deleted the http-request-node-description branch April 27, 2023 15:33
MiloradFilipovic added a commit that referenced this pull request Apr 28, 2023
* master:
  fix(core): Only take into account users that active for the first time to show activation modal (no-changelog) (#6121)
  fix(editor): Change wording for Variables feature available plans (no-changelog) (#6096)
  refactor(editor): Add skip option to activation modal (#6092)
  fix(HTTP Request Node): Add description for 'Specify Body' option (#6114)
  test(editor): Test personal settings view (#6119)
netroy pushed a commit that referenced this pull request May 2, 2023
)

* fix(HTTP Request Node): Add description for 'Specify Body' option

* disable linting for node-param-description-miscased-json
@janober
Copy link
Member

janober commented May 2, 2023

Got released with n8n@0.226.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team node/improvement New feature or request Released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants