Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(core): Improve saml endpoints and audit events #6107

Merged
merged 9 commits into from
Apr 28, 2023
Merged

fix(core): Improve saml endpoints and audit events #6107

merged 9 commits into from
Apr 28, 2023

Conversation

flipswitchingmonkey
Copy link
Contributor

No description provided.

@github-actions
Copy link
Contributor

Great PR! Please pay attention to the following items before merging:

Files matching packages/**:

  • If fixing bug, added test to cover scenario.
  • If addressing forum or Github issue, added link to description.

Files matching packages/**/*.ts:

  • Added unit tests to cover new or updated functionality.

Make sure to check off this list before asking for review.

@n8n-assistant n8n-assistant bot added core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team labels Apr 27, 2023
@flipswitchingmonkey flipswitchingmonkey marked this pull request as ready for review April 27, 2023 11:18
@codecov
Copy link

codecov bot commented Apr 27, 2023 •
edited
Loading

Codecov Report

Patch coverage: 58.82% and project coverage change: +0.05 🎉

Comparison is base (4cbb05b) 19.19% compared to head (2f8da08) 19.25%.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #6107      +/-   ##
==========================================
+ Coverage   19.19%   19.25%   +0.05%     
==========================================
  Files        2589     2589              
  Lines      116890   116926      +36     
  Branches    18339    18346       +7     
==========================================
+ Hits        22439    22514      +75     
+ Misses      93806    93766      -40     
- Partials      645      646       +1
Impacted Files Coverage Δ
packages/cli/src/InternalHooks.ts 6.56% <0.00%> (-0.14%) ⬇️
packages/cli/src/Server.ts 0.00% <0.00%> (ø)
...ages/cli/src/eventbus/EventMessageClasses/index.ts 100.00% <ø> (ø)
packages/cli/src/controllers/auth.controller.ts 76.19% <66.66%> (-0.74%) ⬇️
...ages/cli/src/sso/saml/routes/saml.controller.ee.ts 77.02% <100.00%> (+37.89%) ⬆️

... and 11 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

krynble
krynble suggested changes Apr 28, 2023
View reviewed changes
Copy link
Contributor

@krynble krynble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add tests for those endpoints? Just to make sure we don't have a regression with the middlewares.

Also might make sense we are asserting the calls to the InternalHooks' functions.

@flipswitchingmonkey
Copy link
Contributor Author

Can we add tests for those endpoints? Just to make sure we don't have a regression with the middlewares.

Also might make sense we are asserting the calls to the InternalHooks' functions.

Added tests (and found a permission issue in the process 👍 )

krynble
krynble approved these changes Apr 28, 2023
View reviewed changes
Copy link
Contributor

@krynble krynble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link
Contributor

✅ All Cypress E2E specs passed

@flipswitchingmonkey flipswitchingmonkey merged commit c0b1cdd into master Apr 28, 2023
@flipswitchingmonkey flipswitchingmonkey deleted the pay-393-add-tracking-for-sso-saml branch April 28, 2023 16:11
MiloradFilipovic added a commit that referenced this pull request May 2, 2023
@MiloradFilipovic
Merge branch 'master' into feature/resource-mapping-component
8608aee 
* master: (37 commits)
  fix(editor): Fix copy selection behavior (#6112)
  fix(core): Account for nodes with renamable content (#6109)
  fix(editor): Fix quote handling on dollar-sign variable completions (#6128)
  fix(editor): Fix cropped off completions docstrings (#6129)
  fix(Date & Time Node): Numbers conversions fix
  fix(Merge Node): Do not error if expected key is missing
  fix(core): Improve saml endpoints and audit events (#6107)
  fix: Prevent displaying an endless timer in the execution list for finished executions (#6137)
  fix(editor): Fix `Show details` summary (#6113)
  fix(editor): Fix sidebar button styling (#6138)
  fix(editor): Fix unique names for node duplication (#6134)
  fix(editor): Fix missing `Stop Listening` button (#6125)
  fix(editor): Fix unscrollable node settings (#6133)
  fix(core): Avoid using `Object.keys` on Buffer and other non-plain objects (#6131)
  fix(editor): Change execution list tab loader design (#6120)
  fix(Slack Node): Restore ability to send text in addition of blocks or attachments
  feat(editor): Add support for `loadOptionsDependsOn` to RLC (#6101)
  fix: Correctly allow sharees to test credential when opening the modal (#6111)
  fix(core): Fix `hasOwnProperty` on augmented objects (#6124)
  fix(core): Only take into account users that active for the first time to show activation modal (no-changelog) (#6121)
  ...
MiloradFilipovic added a commit that referenced this pull request May 2, 2023
@MiloradFilipovic
Merge branch 'feature/resource-mapping-component' into NODE-398-resou…
f6d6762 
…rce-mapper-ui-P2

* feature/resource-mapping-component: (37 commits)
  fix(editor): Fix copy selection behavior (#6112)
  fix(core): Account for nodes with renamable content (#6109)
  fix(editor): Fix quote handling on dollar-sign variable completions (#6128)
  fix(editor): Fix cropped off completions docstrings (#6129)
  fix(Date & Time Node): Numbers conversions fix
  fix(Merge Node): Do not error if expected key is missing
  fix(core): Improve saml endpoints and audit events (#6107)
  fix: Prevent displaying an endless timer in the execution list for finished executions (#6137)
  fix(editor): Fix `Show details` summary (#6113)
  fix(editor): Fix sidebar button styling (#6138)
  fix(editor): Fix unique names for node duplication (#6134)
  fix(editor): Fix missing `Stop Listening` button (#6125)
  fix(editor): Fix unscrollable node settings (#6133)
  fix(core): Avoid using `Object.keys` on Buffer and other non-plain objects (#6131)
  fix(editor): Change execution list tab loader design (#6120)
  fix(Slack Node): Restore ability to send text in addition of blocks or attachments
  feat(editor): Add support for `loadOptionsDependsOn` to RLC (#6101)
  fix: Correctly allow sharees to test credential when opening the modal (#6111)
  fix(core): Fix `hasOwnProperty` on augmented objects (#6124)
  fix(core): Only take into account users that active for the first time to show activation modal (no-changelog) (#6121)
  ...
@janober
Copy link
Member

janober commented May 3, 2023

Got released with n8n@0.227.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krynble krynble krynble approved these changes

Assignees
No one assigned
Labels
core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team Released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@flipswitchingmonkey @janober @krynble @netroy