Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Prevent skipping of E2E fail job (no-changelog) #5958

Merged
merged 5 commits into from
Apr 12, 2023
Merged
Show file tree
Hide file tree
Changes from 3 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions .github/workflows/e2e-tests-pr.yml
Original file line number Diff line number Diff line change
Expand Up @@ -37,9 +37,10 @@ jobs:
runs-on: ubuntu-latest
name: E2E [Electron/Node 16] - Checks
needs: [run-e2e-tests]
if: always()
steps:
- name: E2E success comment
if: success()
if: needs.run-e2e-tests.result == 'success'
uses: peter-evans/create-or-update-comment@v3
with:
issue-number: ${{ github.event.pull_request.number }}
Expand All @@ -48,10 +49,14 @@ jobs:
token: ${{ secrets.GITHUB_TOKEN }}

- name: E2E fail comment
if: failure()
if: needs.run-e2e-tests.result == 'failure'
uses: peter-evans/create-or-update-comment@v3
with:
issue-number: ${{ github.event.pull_request.number }}
body: |
:warning: Some Cypress E2E specs are failing, please fix them before merging
token: ${{ secrets.GITHUB_TOKEN }}

- name: Fail job if run-e2e-tests failed
if: needs.run-e2e-tests.result == 'failure'
run: exit 1
1 change: 1 addition & 0 deletions cypress/e2e/1-workflows.cy.ts
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ describe('Workflows', () => {

beforeEach(() => {
cy.visit(WorkflowsPage.url);
cy.get('body').should('contain', 'This wont work 123');
});

it('should create a new workflow using empty state card', () => {
Expand Down