Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Metabase Node): Fix issue with question results not correctly being returned #5665

Merged
merged 2 commits into from
Mar 14, 2023

Conversation

Joffcom
Copy link
Member

@Joffcom Joffcom commented Mar 10, 2023

Github issue / Community forum post (link here to close automatically): https://community.n8n.io/t/metabase-node-returns-just-the-first-row-of-the-question/22371

@github-actions
Copy link
Contributor

Great PR! Please pay attention to the following items before merging:

Files matching packages/**:

  • If fixing bug, added test to cover scenario.
  • If addressing forum or Github issue, added link to description.

Files matching packages/**/*.ts:

  • Added unit tests to cover new or updated functionality.

Files matching packages/nodes-base/nodes/**:

  • Added workflow tests for nodes if possible.

Make sure to check off this list before asking for review.

@n8n-assistant n8n-assistant bot added n8n team Authored by the n8n team node/improvement New feature or request labels Mar 10, 2023
Copy link
Contributor

@maspio maspio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Joffcom Joffcom merged commit d1e3c19 into master Mar 14, 2023
@Joffcom Joffcom deleted the node-246 branch March 14, 2023 17:47
@n8n-assistant n8n-assistant bot added the Upcoming Release Will be part of the upcoming release label Mar 14, 2023
@janober
Copy link
Member

janober commented Mar 16, 2023

Got released with n8n@0.220.0

@janober janober removed the Upcoming Release Will be part of the upcoming release label Mar 16, 2023
sunilrr pushed a commit to fl-g6/qp-n8n that referenced this pull request Apr 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team node/improvement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants