Restore i18n post-UM #3072
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -57,15 +57,7 @@ export default Vue.extend({ | |
| }, | ||
| rows(): ITagRow[] { | ||
| const getUsage = (count: number | undefined) => count && count > 0 | ||
| ? this.$locale.baseText('tagsView.inUse', { adjustToNumber: count }) | ||
| : this.$locale.baseText('tagsView.notBeingUsed'); | ||
|
|
||
| const disabled = this.isCreateEnabled || this.$data.updateId || this.$data.deleteId; | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -2,27 +2,33 @@ | |
|
|
||
| ## Base text | ||
|
There was a problem hiding this comment. thanks for updating the guide. can you also update section that says we should use first words of a message? I think I saw this in a previous PR. Instead names should be more descriptive. There was a problem hiding this comment. That section was in the other PR that was not merged. I intentionally left that part out. Edit: To expand, the current keys still reference file structure. Not sure if we should add any recommendations that are not being followed yet. |
||
|
|
||
| ### Pluralization | ||
|
|
||
| Certain base text strings accept [singular and plural versions](https://kazupon.github.io/vue-i18n/guide/pluralization.html) separated by a `|` character: | ||
|
|
||
| ```json | ||
| { | ||
| "tagsView.inUse": "{count} workflow | {count} workflows", | ||
| } | ||
| ``` | ||
|
|
||
| ### Interpolation | ||
|
|
||
| Certain base text strings use [interpolation](https://kazupon.github.io/vue-i18n/guide/formatting.html#named-formatting) to allow for a variable between curly braces: | ||
|
|
||
| ```json | ||
| { | ||
| "stopExecution.message": "The execution with the ID {activeExecutionId} got stopped!", | ||
| "stopExecution.title": "Execution stopped" | ||
| } | ||
| ``` | ||
|
|
||
| When translating a string containing an interpolated variable, leave the variable untranslated: | ||
|
|
||
| ```json | ||
| { | ||
| "stopExecution.message": "Die Ausführung mit der ID {activeExecutionId} wurde gestoppt", | ||
| "stopExecution.title": "Execution stopped" | ||
| } | ||
| ``` | ||
|
|
||
|
|
@@ -32,18 +38,12 @@ As a convenience, the base text file may contain the special key `reusableBaseTe | |
|
|
||
| ```json | ||
| { | ||
| "reusableBaseText.save": "🇩🇪 Save", | ||
| "duplicateWorkflowDialog.enterWorkflowName": "🇩🇪 Enter workflow name", | ||
| "duplicateWorkflowDialog.save": "@:reusableBaseText.save", | ||
| "saveButton.save": "@:reusableBaseText.save", | ||
| "saveButton.saving": "🇩🇪 Saving", | ||
| "saveButton.saved": "🇩🇪 Saved", | ||
| } | ||
| ``` | ||
|
|
||
|
|
@@ -92,23 +92,27 @@ Currently only the keys `oauth.clientId` and `oauth.clientSecret` are supported | |
|
|
||
| ```json | ||
| { | ||
| "reusableDynamicText.oauth2.clientId": "🇩🇪 Client ID", | ||
| "reusableDynamicText.oauth2.clientSecret": "🇩🇪 Client Secret", | ||
| } | ||
| ``` | ||
|
|
||
| ### Special cases | ||
|
|
||
| `eventTriggerDescription` and `activationMessage` are dynamic node properties that are not part of node parameters. To translate them, set the key at the root level of the `nodeView` property in the node translation file. | ||
|
|
||
| Webhook node: | ||
|
|
||
| ```json | ||
| { | ||
| "nodeView.eventTriggerDescription": "🇩🇪 Waiting for you to call the Test URL", | ||
| } | ||
| ``` | ||
|
|
||
| Cron node: | ||
|
|
||
| ```json | ||
| { | ||
| "nodeView.activationMessage": "🇩🇪 'Your cron trigger will now trigger executions on the schedule you have defined." | ||
| } | ||
| ``` | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -6,6 +6,7 @@ n8n allows for internalization of the majority of UI text: | |
|
|
||
| - base text, e.g. menu display items in the left-hand sidebar menu, | ||
| - node text, e.g. parameter display names and placeholders in the node view, | ||
| - credential text, e.g. parameter display names and placeholders in the credential modal, | ||
| - header text, e.g. node display names and descriptions at various spots. | ||
|
|
||
| Currently, n8n does _not_ allow for internalization of: | ||
|
|
@@ -55,12 +56,10 @@ Base text is rendered with no dependencies, i.e. base text is fixed and does not | |
| The base text file for each locale is located at `/packages/editor-ui/src/plugins/i18n/locales/` and is named `{localeIdentifier}.json`. Keys in the base text file can be Vue component dirs, Vue component names, and references to symbols in those Vue components. These keys are added by the team as the UI is modified or expanded. | ||
|
|
||
| ```json | ||
| { | ||
| "nodeCreator.categoryNames.analytics": "🇩🇪 Analytics", | ||
| "nodeCreator.categoryNames.communication": "🇩🇪 Communication", | ||
| "nodeCreator.categoryNames.coreNodes": "🇩🇪 Core Nodes" | ||
| } | ||
| ``` | ||
|
|
||
|
|
@@ -98,9 +97,9 @@ A credential translation file is placed at `/nodes-base/credentials/translations | |
| ``` | ||
| credentials | ||
| └── translations | ||
| └── de | ||
| ├── githubApi.json | ||
| └── githubOAuth2Api.json | ||
| ``` | ||
| Every credential must have its own credential translation file. | ||
|
|
||
|
|
@@ -123,9 +122,9 @@ GitHub | |
| ├── GitHub.node.ts | ||
| ├── GitHubTrigger.node.ts | ||
| └── translations | ||
| └── de | ||
| ├── github.json | ||
| └── githubTrigger.json | ||
| ``` | ||
|
|
||
| Every node must have its own node translation file. | ||
|
|
@@ -184,16 +183,10 @@ The object for each node credential parameter allows for the keys `displayName`, | |
|
|
||
| ```json | ||
| { | ||
| "server.displayName": "🇩🇪 Github Server", | ||
| "server.description": "🇩🇪 The server to connect to. Only has to be set if Github Enterprise is used.", | ||
| "user.placeholder": "🇩🇪 Hans", | ||
| "accessToken.placeholder": "🇩🇪 123", | ||
| } | ||
| ``` | ||
|
|
||
|
|
@@ -224,10 +217,8 @@ export class Github implements INodeType { | |
|
|
||
| ```json | ||
| { | ||
| "header.displayName": "🇩🇪 GitHub", | ||
| "header.description": "🇩🇪 Consume GitHub API", | ||
| } | ||
| ``` | ||
|
|
||
|
|
@@ -264,11 +255,7 @@ export class Github implements INodeType { | |
|
|
||
| ```json | ||
| { | ||
| "nodeView.resource.displayName": "🇩🇪 Resource", | ||
| } | ||
| ``` | ||
|
|
||
|
|
@@ -291,13 +278,9 @@ Allowed keys: `displayName`, `description`, `placeholder` | |
|
|
||
| ```json | ||
| { | ||
| "nodeView.owner.displayName": "🇩🇪 Repository Owner", | ||
| "nodeView.owner.placeholder": "🇩🇪 n8n-io", | ||
| "nodeView.owner.description": "🇩🇪 Owner of the repository", | ||
| } | ||
| ``` | ||
|
|
||
|
|
@@ -333,20 +316,10 @@ Allowed subkeys: `options.{optionName}.displayName` and `options.{optionName}.de | |
|
|
||
| ```json | ||
| { | ||
| "nodeView.resource.displayName": "🇩🇪 Resource", | ||
| "nodeView.resource.description": "🇩🇪 Resource to operate on", | ||
| "nodeView.resource.options.file.displayName": "🇩🇪 File", | ||
| "nodeView.resource.options.issue.displayName": "🇩🇪 Issue", | ||
| } | ||
| ``` | ||
|
|
||
|
|
@@ -394,19 +367,11 @@ Example of `collection` parameter: | |
|
|
||
| ```json | ||
| { | ||
| "nodeView.labels.displayName": "🇩🇪 Labels", | ||
| "nodeView.labels.multipleValueButtonText": "🇩🇪 Add Label", | ||
| "nodeView.labels.options.label.displayName": "🇩🇪 Label", | ||
| "nodeView.labels.options.label.description": "🇩🇪 Label to add to issue", | ||
| "nodeView.labels.options.label.placeholder": "🇩🇪 Some placeholder" | ||
| } | ||
| ``` | ||
|
|
||
|
|
@@ -461,29 +426,15 @@ Example of `fixedCollection` parameter: | |
|
|
||
| ```json | ||
| { | ||
| "nodeView.additionalParameters.displayName": "🇩🇪 Additional Parameters", | ||
| "nodeView.additionalParameters.placeholder": "🇩🇪 Add Field", | ||
| "nodeView.additionalParameters.options.author.displayName": "🇩🇪 Author", | ||
| "nodeView.additionalParameters.options.author.values.name.displayName": "🇩🇪 Name", | ||
| "nodeView.additionalParameters.options.author.values.name.description": "🇩🇪 Name of the author of the commit", | ||
| "nodeView.additionalParameters.options.author.values.name.placeholder": "🇩🇪 Jan", | ||
| "nodeView.additionalParameters.options.author.values.email.displayName": "🇩🇪 Email", | ||
| "nodeView.additionalParameters.options.author.values.email.description": "🇩🇪 Email of the author of the commit", | ||
| "nodeView.additionalParameters.options.author.values.email.placeholder": "🇩🇪 jan@n8n.io", | ||
| } | ||
| ``` | ||
|
|
||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ivov Why are we using a sync method here? Could we not simply use an async one?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, switched to promisified
access, still working:There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great thanks for the fast fix!