-
Notifications
You must be signed in to change notification settings - Fork 7.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor misc endpoints for user management #2707
Refactor misc endpoints for user management #2707
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor (and even optional) changes - let me know your thoughts.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should unify error messsages like 'No encryption key got found to decrypt the credentials!'
somehow, for example as constants in a constants file, so we can reuse them on testing 👍🏼
// @ts-ignore | ||
additionalData.userId = (req.user as User).id; | ||
|
||
additionalData.userId = req.user.id; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why we need to add this here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not my work, but likely because of this: #2697
/oauth1-credential/auth
/oauth2-credential/auth
/oauth1-credential/callback
/oauth2-credential/callback
/node-parameter-options
/user-survey/test-webhook/:id/data/:path