Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor misc endpoints for user management #2707

Merged

Conversation

ivov
Copy link
Contributor

@ivov ivov commented Jan 19, 2022

/oauth1-credential/auth
/oauth2-credential/auth
/oauth1-credential/callback
/oauth2-credential/callback
/node-parameter-options
/user-survey
/test-webhook/:id
/data/:path

@ivov ivov added feature Large self-contained feature n8n team Authored by the n8n team labels Jan 19, 2022
Copy link
Contributor

@krynble krynble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor (and even optional) changes - let me know your thoughts.

packages/cli/src/Server.ts Outdated Show resolved Hide resolved
packages/cli/src/Server.ts Outdated Show resolved Hide resolved
packages/cli/src/Server.ts Outdated Show resolved Hide resolved
packages/cli/src/Server.ts Outdated Show resolved Hide resolved
packages/cli/src/Server.ts Outdated Show resolved Hide resolved
packages/cli/src/Server.ts Outdated Show resolved Hide resolved
Copy link
Contributor

@BHesseldieck BHesseldieck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should unify error messsages like 'No encryption key got found to decrypt the credentials!' somehow, for example as constants in a constants file, so we can reuse them on testing 👍🏼

packages/cli/src/Server.ts Outdated Show resolved Hide resolved
// @ts-ignore
additionalData.userId = (req.user as User).id;

additionalData.userId = req.user.id;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why we need to add this here?

Copy link
Contributor Author

@ivov ivov Jan 27, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not my work, but likely because of this: #2697

packages/cli/src/Server.ts Outdated Show resolved Hide resolved
packages/cli/src/Server.ts Outdated Show resolved Hide resolved
packages/cli/src/Server.ts Outdated Show resolved Hide resolved
packages/cli/src/Server.ts Outdated Show resolved Hide resolved
@BHesseldieck BHesseldieck merged commit ff66718 into user-management-backend Jan 27, 2022
@BHesseldieck BHesseldieck deleted the user-management-backend-misc-endpoints branch January 27, 2022 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Large self-contained feature n8n team Authored by the n8n team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants