Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update import workflows command for user management #2701

Merged

Conversation

ivov
Copy link
Contributor

@ivov ivov commented Jan 19, 2022

./packages/cli/bin/n8n import:workflow --input=file.json
./packages/cli/bin/n8n import:workflow --separate --input=myDir/

Pinned chokidar to fix build: #2696

@ivov ivov added feature Large self-contained feature n8n team Authored by the n8n team labels Jan 19, 2022
@ivov ivov changed the title Update import command for user management Update import workflows command for user management Jan 19, 2022
@krynble
Copy link
Contributor

krynble commented Jan 20, 2022

I'd say we add an optional CLI argumento userId that allows you to select to which user save the workflows. Still uses owner in case it doesn't exist.

Also I vote for the getInstanceOwner function here to be the same as the one provided by the UserManagementHelper so we consolidate the healing behavior on a single place, for the reset command.

Tell me your thoughts about this @ivov

packages/cli/commands/import/workflow.ts Outdated Show resolved Hide resolved
packages/cli/commands/import/workflow.ts Outdated Show resolved Hide resolved
packages/cli/commands/import/workflow.ts Outdated Show resolved Hide resolved
packages/cli/commands/import/workflow.ts Outdated Show resolved Hide resolved
packages/cli/commands/import/workflow.ts Outdated Show resolved Hide resolved
Copy link
Contributor

@BHesseldieck BHesseldieck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just one naming suggestion otherwise 🚀

packages/cli/commands/import/workflow.ts Outdated Show resolved Hide resolved
packages/cli/commands/import/workflow.ts Outdated Show resolved Hide resolved
packages/cli/commands/import/workflow.ts Outdated Show resolved Hide resolved
@BHesseldieck BHesseldieck merged commit fe07ead into user-management-backend Jan 27, 2022
@BHesseldieck BHesseldieck deleted the user-management-backend-import-command branch January 27, 2022 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Large self-contained feature n8n team Authored by the n8n team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants