N8n 2349 workflow canvas revamp #2388
Conversation
| ], | ||
| methods: { | ||
| __addNode (node: INodeUi) { |
There was a problem hiding this comment.
refactor this giant function into three distinct functions..
| isSource: false, | ||
| isTarget: !this.isReadOnly, | ||
| parameters: { | ||
| nodeIndex: this.nodeIndex, | ||
| type: inputName, | ||
| index, | ||
| }, | ||
| dragAllowedWhenFull: inputData.dragAllowedWhenFull, | ||
| enabled: !this.isReadOnly, |
There was a problem hiding this comment.
fixes bug where you can pull connections in executions FROM INPUTS
| isTarget: false, | ||
| enabled: !this.isReadOnly, |
There was a problem hiding this comment.
fixes bug where you can pull connections in executions from inputs
| <div :class="{'node-wrapper': true, selected: isSelected}" :style="nodePosition"> | ||
| <div class="select-background" v-show="isSelected"></div> | ||
| <div :class="{'node-default': true, 'touch-active': isTouchActive, 'is-touch-device': isTouchDevice}" :data-name="data.name" :ref="data.name"> | ||
| <div :class="nodeClass" :style="nodeStyle" @dblclick="setNodeActive" @click.left="mouseLeftClick" v-touch:start="touchStart" v-touch:end="touchEnd"> |
There was a problem hiding this comment.
added a wrapper to keep options hoverable within node box but also have different z-index...
| } catch (e) { | ||
| console.error(e); // eslint-disable-line no-console | ||
| return true; | ||
| } |
There was a problem hiding this comment.
why wrap all binds with try/catch? because jsplumb has try /catch at bind level but it removes details.. this makes it easier to pin down errors
| /** | ||
| * Custom connector type | ||
| * Based on jsplumb Flowchart and Bezier types | ||
| * | ||
| * https://github.com/jsplumb/jsplumb | ||
| * https://github.com/jsplumb/jsplumb/blob/fb5fce52794fa52306825bdaa62bf3855cdfd7e0/src/connectors-flowchart.js | ||
| * https://github.com/jsplumb/jsplumb/blob/fb5fce52794fa52306825bdaa62bf3855cdfd7e0/src/connectors-bezier.js | ||
| * | ||
| * Dual licensed under the MIT and GPL2 licenses. | ||
| */ |
There was a problem hiding this comment.
for legal reasons, checking with Jan on this
| this.overrideTargetEndpoint = null; | ||
| }; | ||
|
|
||
| this._compute = function (originalPaintInfo, params) { |
There was a problem hiding this comment.
entry point for drawing connectors
| if (diffX < (-1 * loopbackMinimum)) { | ||
| // loop backward behavior | ||
| midy = paintInfo.startStubY - (diffX < 0 ? direction * loopbackVerticalLength : 0); | ||
| } else { | ||
| // original flowchart behavior | ||
| midy = paintInfo.startStubY + ((paintInfo.endStubY - paintInfo.startStubY) * midpoint); | ||
| } |
There was a problem hiding this comment.
sorcery by which loops happen
| } | ||
| }; | ||
|
|
||
| const lineCalculators = { |
There was a problem hiding this comment.
I removed other types of flows... when endpoints are perpendicular or orthogonal... to avoid lots of dead code.. can add them back if needed
|
Amazing work. Got merged. Thanks a lot! |
|
Got released with |
n8n-assistant
bot
added
n8n team
No description provided.