Add Nodes: AWS SecretsManager, AWS Kinesis Firehose, Eventbrite, Eloqua, SuiteCrm, Zammad, ActiveCampaign(API V1) #2205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quansenB
changed the title
|
Thanks a lot for this great PR. Can you please submit an individual PR for each node. Having one PR with 7 nodes has sadly the effect that it will probably never move forward as pushing 7 through in parallel through the internal review process is simply incredibly complicated. Having them separate would make that much easier and would speed that up a lot. Thanks! |
|
Thank you for this big contribution. Would it be possible for you to merge master into this PR and fix the conflicts? This way we can create separate branches for individual nodes, while preserving your attribution as authors. |
ivov
added
node/new
This was referenced Dec 28, 2021
Closed
|
Closing as this has been split up. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds partial API support for the nodes mentioned in the title.