Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(core): Port 3 more controllers to use DTOs (no-changelog) #12375

Merged
merged 5 commits into from
Dec 26, 2024

Conversation

netroy
Copy link
Member

@netroy netroy commented Dec 26, 2024

Summary

Continued from #12373

Review / Merge checklist

  • PR title and summary are descriptive. (conventions)
  • Docs updated or follow-up ticket created.
  • Tests included.
  • PR Labeled with release/backport (if the PR is an urgent fix that needs to be backported)

@n8n-assistant n8n-assistant bot added core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team labels Dec 26, 2024
Copy link

codecov bot commented Dec 26, 2024

Codecov Report

Attention: Patch coverage is 90.00000% with 7 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
packages/@n8n/api-types/src/dto/index.ts 0.00% 7 Missing ⚠️

📢 Thoughts on this report? Let us know!

RicardoE105
RicardoE105 previously approved these changes Dec 26, 2024
Copy link
Contributor

@RicardoE105 RicardoE105 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

Base automatically changed from CAT-455-port-over-more-dtos to master December 26, 2024 14:31
@netroy netroy dismissed RicardoE105’s stale review December 26, 2024 14:31

The base branch was changed.

RicardoE105
RicardoE105 previously approved these changes Dec 26, 2024
@netroy netroy dismissed RicardoE105’s stale review December 26, 2024 14:45

The merge-base changed after approval.

Copy link

cypress bot commented Dec 26, 2024

n8n    Run #8472

Run Properties:  status check passed Passed #8472  •  git commit 17e56264e6: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 netroy 🗃️ e2e/*
Project n8n
Branch Review CAT-455-port-over-more-dtos-part-2
Run status status check passed Passed #8472
Run duration 04m 41s
Commit git commit 17e56264e6: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 netroy 🗃️ e2e/*
Committer कारतोफ्फेलस्क्रिप्ट™
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 1
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 483
View all changes introduced in this branch ↗︎

Copy link
Contributor

✅ All Cypress E2E specs passed

@netroy netroy merged commit 371a09d into master Dec 26, 2024
38 checks passed
@netroy netroy deleted the CAT-455-port-over-more-dtos-part-2 branch December 26, 2024 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants