Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(editor): Set RunData outputIndex based on incoming data #12182

Merged
merged 4 commits into from
Dec 17, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions cypress/e2e/5-ndv.cy.ts
Original file line number Diff line number Diff line change
Expand Up @@ -837,4 +837,18 @@ describe('NDV', () => {
.contains('To search field contents rather than just names, use Table or JSON view')
.should('exist');
});

it('ADO-2931 - should handle multiple branches of the same input with the first branch empty correctly', () => {
cy.createFixtureWorkflow('Test_ndv_two_branches_of_same_parent_false_populated.json');
workflowPage.actions.zoomToFit();
workflowPage.actions.openNode('DebugHelper');
ndv.getters.inputPanel().should('be.visible');
ndv.getters.outputPanel().should('be.visible');
ndv.actions.execute();
// This ensures we rendered the inputPanel
ndv.getters
.inputPanel()
.find('[data-test-id=run-data-schema-item]')
.should('contain.text', 'a1');
});
});
Original file line number Diff line number Diff line change
@@ -0,0 +1,94 @@
{
"nodes": [
{
"parameters": {
"conditions": {
"options": {
"caseSensitive": true,
"leftValue": "",
"typeValidation": "strict",
"version": 2
},
"conditions": [
{
"id": "6f0cf983-824b-4339-a5de-6b374a23b4b0",
"leftValue": "={{ $json.a }}",
"rightValue": 3,
"operator": {
"type": "number",
"operation": "equals"
}
}
],
"combinator": "and"
},
"options": {}
},
"type": "n8n-nodes-base.if",
"typeVersion": 2.2,
"position": [220, 0],
"id": "1755282a-ec4a-4d02-a833-0316ca413cc4",
"name": "If"
},
{
"parameters": {},
"type": "n8n-nodes-base.manualTrigger",
"typeVersion": 1,
"position": [0, 0],
"id": "de1e7acf-12d8-4e56-ba42-709ffb397db2",
"name": "When clicking ‘Test workflow’"
},
{
"parameters": {
"category": "randomData"
},
"type": "n8n-nodes-base.debugHelper",
"typeVersion": 1,
"position": [580, 0],
"id": "86440d33-f833-453c-bcaa-fff7e0083501",
"name": "DebugHelper",
"alwaysOutputData": true
}
],
"connections": {
"If": {
"main": [
[
{
"node": "DebugHelper",
"type": "main",
"index": 0
}
],
[
{
"node": "DebugHelper",
"type": "main",
"index": 0
}
]
]
},
"When clicking ‘Test workflow’": {
"main": [
[
{
"node": "If",
"type": "main",
"index": 0
}
]
]
}
},
"pinData": {
"When clicking ‘Test workflow’": [
{
"a": 1
},
{
"a": 2
}
]
}
}
16 changes: 15 additions & 1 deletion packages/editor-ui/src/components/RunData.vue
Original file line number Diff line number Diff line change
Expand Up @@ -547,6 +547,10 @@ watch(node, (newNode, prevNode) => {

watch(hasNodeRun, () => {
if (props.paneType === 'output') setDisplayMode();
else {
// InputPanel relies on the outputIndex to check if we have data
outputIndex.value = determineInitialOutputIndex();
}
});

watch(
Expand Down Expand Up @@ -1080,9 +1084,19 @@ function getDataCount(
return getFilteredData(pinOrLiveData).length;
}

function determineInitialOutputIndex() {
for (let i = 0; i <= maxOutputIndex.value; i++) {
if (getRawInputData(props.runIndex, i).length) {
return i;
}
}

return 0;
}

function init() {
// Reset the selected output index every time another node gets selected
outputIndex.value = 0;
outputIndex.value = determineInitialOutputIndex();
refreshDataSize();
closeBinaryDataDisplay();
let outputTypes: NodeConnectionType[] = [];
Expand Down
Loading