Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add solarwinds ipam credentials #12005

Merged
merged 14 commits into from
Dec 19, 2024

Conversation

Stamsy
Copy link
Contributor

@Stamsy Stamsy commented Dec 2, 2024

Summary

Add new basic authentication credentials for SolarWinds IPAM.

Review / Merge checklist

  • PR title and summary are descriptive. (conventions)
  • Docs updated or follow-up ticket created.
  • Tests included.
  • PR Labeled with release/backport (if the PR is an urgent fix that needs to be backported)

Copy link

codecov bot commented Dec 2, 2024

Codecov Report

Attention: Patch coverage is 0% with 9 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...-base/credentials/SolarWindsIpamApi.credentials.ts 0.00% 9 Missing ⚠️

📢 Thoughts on this report? Let us know!

@n8n-assistant n8n-assistant bot added community Authored by a community member in linear Issue or PR has been created in Linear for internal review labels Dec 2, 2024
@Joffcom
Copy link
Member

Joffcom commented Dec 2, 2024

Hey @Stamsy,

Thanks for the PR, We have created "GHC-546" as the internal reference to get this reviewed.

One of us will be in touch if there are any changes needed, in most cases this is normally within a couple of weeks but it depends on the current workload of the team.

@Stamsy Stamsy changed the title feat: WIP Add solarwinds ipam credentials feat: Add solarwinds ipam credentials Dec 9, 2024
Joffcom
Joffcom previously approved these changes Dec 10, 2024
Copy link
Member

@Joffcom Joffcom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good thanks 🙏

Joffcom
Joffcom previously approved these changes Dec 16, 2024
@Joffcom Joffcom merged commit 882484e into n8n-io:master Dec 19, 2024
21 of 22 checks passed
@github-actions github-actions bot mentioned this pull request Dec 19, 2024
@janober
Copy link
Member

janober commented Dec 19, 2024

Got released with n8n@1.73.0

riascho pushed a commit that referenced this pull request Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community Authored by a community member in linear Issue or PR has been created in Linear for internal review Released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants