feat(editor): Params pane collection improvements #11607
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
n8n-assistant
bot
added
n8n team
ShireenMissi
force-pushed
the
node-1475-params-pane-collection-improvements
branch
3 times, most recently
from
cfc9cfb to
7752658
Compare
Codecov ReportAttention: Patch coverage is
📢 Thoughts on this report? Let us know! |
ShireenMissi
force-pushed
the
node-1475-params-pane-collection-improvements
branch
3 times, most recently
from
f668f15 to
32f7c34
Compare
elsmr
previously approved these changes
Dec 3, 2024
packages/editor-ui/src/components/AssignmentCollection/AssignmentCollection.vue
Show resolved
Hide resolved
packages/editor-ui/src/components/AssignmentCollection/AssignmentCollection.vue
Outdated
Show resolved
Hide resolved
packages/editor-ui/src/components/FilterConditions/Condition.vue
Outdated
Show resolved
Hide resolved
ShireenMissi
force-pushed
the
node-1475-params-pane-collection-improvements
branch
4 times, most recently
from
c3c2ed6 to
fa555a7
Compare
elsmr
previously approved these changes
Dec 17, 2024
|
✅ No visual regressions found. |
|
|
n8n
|
||||||||||||||||||||||||||||
| Project |
n8n
|
| Branch Review |
node-1475-params-pane-collection-improvements
|
| Run status |
|
| Run duration | 04m 43s |
| Commit |
|
| Committer | Shireen Missi |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
1
|
Pending
|
0
|
Skipped
|
0
|
Passing
|
480
|
| View all changes introduced in this branch ↗︎ | |
ShireenMissi
force-pushed
the
node-1475-params-pane-collection-improvements
branch
2 times, most recently
from
24c9c92 to
c8da540
Compare
Co-authored-by: Elias Meire <elsmr@users.noreply.github.com>
ShireenMissi
force-pushed
the
node-1475-params-pane-collection-improvements
branch
from
c8da540 to
b630fc0
Compare
elsmr
approved these changes
Dec 18, 2024
|
✅ No visual regressions found. |
|
✅ All Cypress E2E specs passed |
ShireenMissi
deleted the
node-1475-params-pane-collection-improvements
branch
Merged
|
Got released with |
riascho
pushed a commit
that referenced
this pull request
Jan 14, 2025
Co-authored-by: Elias Meire <elsmr@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR improves the UX for parameter collections by making the following changes:
Draggable elements have two icons on the left: 1. Drag icon, 2. Trash icon. The drag icon allows you to drag the item to change the position
Icon colors
Replace the actual arrows down/up we have
Related Linear tickets, Github issues, and Community forum posts
https://linear.app/n8n/issue/NODE-1475/params-pane-collection-improvements
Review / Merge checklist
release/backport(if the PR is an urgent fix that needs to be backported)