Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contributing documentation is out of date #10002

Open
cgsmith opened this issue Jul 10, 2024 · 3 comments
Open

Contributing documentation is out of date #10002

cgsmith opened this issue Jul 10, 2024 · 3 comments

Comments

@cgsmith
Copy link

cgsmith commented Jul 10, 2024

Bug Description

The contribution markdown contains the wrong version of Node referenced.

image

To Reproduce

  1. Download n8n repo
  2. Install Node 18.10
  3. Receive error on pnpm install command

Expected behavior

pnpm install should proceed correctly.

Operating System

Pop!_OS 22.04 LTS

n8n Version

1.50.0 (master)

Node.js Version

18.10.0

Database

SQLite (default)

Execution mode

main (default)

@cgsmith
Copy link
Author

cgsmith commented Jul 10, 2024

So my PR #10003 might not be right. When trying pnpm start after pnpm build on node 18.12 it fails saying n8n requires v18.17.0

I think the versions should be bumped to at least 18.17 as a requirement if that is the case.

@Joffcom
Copy link
Member

Joffcom commented Jul 10, 2024

Great spot, as our minimum is 18.17.0 we should probably use that in the docs.

Let me check with the team to confirm.

@cgsmith
Copy link
Author

cgsmith commented Sep 25, 2024

Updates?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants